In a get column slicing, schema omitted in some instances with Helper.ConvertColumnToFluentColumn #53

Closed
gillotte opened this Issue Aug 27, 2012 · 1 comment

Comments

Projects
None yet
2 participants
Contributor

gillotte commented Aug 27, 2012

I discovered what I believe is a bug while working with the cf.GetSingle method. Thankfully it seems to be a trivial fix which I propose below

This seems to cause the unnecessary byte reversing of text fields, and other issues I'm sure. The schema is in context of the operating method but simply isn't passed to the helper class

  \src\Operations\GetColumnFamilyIndexedSlices.cs(40): return Helper.ConvertColumnToFluentColumn(col.Column);
  \src\Operations\GetColumnFamilyRangeSlices.cs(36): return Helper.ConvertColumnToFluentColumn(col.Column);
  \src\Operations\GetColumnFamilySlice.cs(46):  var r = Helper.ConvertColumnToFluentColumn(result.Column);

I believe should be

  \src\Operations\GetColumnFamilyIndexedSlices.cs(40): return Helper.ConvertColumnToFluentColumn(col.Column, schema);
  \src\Operations\GetColumnFamilyRangeSlices.cs(36): return Helper.ConvertColumnToFluentColumn(col.Column, schema);
  \src\Operations\GetColumnFamilySlice.cs(46):  var r = Helper.ConvertColumnToFluentColumn(result.Column, schema);

nberardi added a commit that referenced this issue Aug 27, 2012

fixed issue #53 where schema wasn't being passed in to the column cre…
…ation, also fixed a bunch of other issues of the same type by removing the optional parameter from the Helper methods
Contributor

nberardi commented Aug 27, 2012

You are right thanks for tracking this issue down for me. I have updated the source code, I will roll this into the next nuget release.

@nberardi nberardi closed this Aug 27, 2012

@ghost ghost assigned nberardi Oct 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment