Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Escape DEFAULT constraint names #345

Merged
merged 2 commits into from Dec 14, 2012

Conversation

Projects
None yet
3 participants
Contributor

Pathoschild commented Dec 6, 2012

Quoted default-value constraint names for SQL Server. This avoids errors when a table name contains dots, which led to invalid constraint names (like DF_table.name_column).

Contributor

daniellee commented Dec 8, 2012

Dots in your table names 😮

The change looks good but any chance you could write a test for it? Thanks.

Contributor

Pathoschild commented Dec 10, 2012

Done. :)

@ghost ghost assigned tommarien Dec 14, 2012

@tommarien tommarien added a commit that referenced this pull request Dec 14, 2012

@tommarien tommarien Merge pull request #345 of Pathoschild/escape-default-constraint-names
# By Pathoschild
# Via Pathoschild
* pr/n345_Pathoschild:
  fixed unit tests for default values
  fixed: DEFAULT constraint names not escaped.
92fc95d

@tommarien tommarien merged commit c133a15 into fluentmigrator:master Dec 14, 2012

Owner

tommarien commented Dec 14, 2012

@Pathoschild thanks for the nice work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment