Added description support for migrations #401

Merged
merged 2 commits into from Dec 29, 2013

Conversation

Projects
None yet
5 participants
Contributor

mizalewski commented Apr 22, 2013

I added description support for MigrationAttribute, which will be also stored in database after migration.

Signed-off-by: Michał Zalewski michal@mzalewski.net

Added description support for migrations
Signed-off-by: Michał Zalewski <michal@mzalewski.net>
Contributor

daniellee commented Apr 23, 2013

Thanks for the Pull Request. I'll have to have a think about this. Changes to the VersionInfo table are always tricky as it can easily be a breaking change.

Contributor

mizalewski commented Apr 26, 2013

OK. In order to avoid breaking changes with previously migrated databases I used nullable column and I added separate constructors which supports description in all public interfaces/classes which I modified (old constructors exists not changed). Current I'm using modified version in my projects (new created and in production), which has already applied migrations.

jeanml commented Oct 28, 2013

Any idea when/if this is going be included in an official release? We'd be quite keen to use this feature.

Contributor

mizalewski commented Nov 5, 2013

jeanml: We created version for our internal use, which have this feature, you found it at nuget: http://www.nuget.org/packages/CrazySoftware.FluentMigrator/

jeanml commented Nov 5, 2013

i'll have a look! thanks Michał.

Owner

tommarien commented Dec 6, 2013

@jeanml I'll take a look at it asap

@ghost ghost assigned tommarien Dec 6, 2013

Owner

tommarien commented Dec 16, 2013

Why not using the classname for the migration like

M0001_Create_Table_table ??

jeanml commented Dec 16, 2013

That's basically what we're doing, but the class name doesn't show up in the VersionInfo table either. The idea was to enrich the information about the migration in the table so that it is not necessary to cross-reference migrations with our source code. Bear in mind that this table is often looked at by QA/non-developers/support teams to troubleshoot issues.

Not a critical issue by all means, but it would be nice to have it included in the official release :)

sloncho commented Dec 26, 2013

+1, please include this in the main repo. Thanks.

tommarien added a commit that referenced this pull request Dec 29, 2013

Merge pull request #401 of drucik86/master
# By Michał Zalewski (1) and Tom Marien (1)
# Via Tom Marien (2) and Michał Zalewski (1)
* drucik86-master:
  Fix issue with versionloader and fix tests
  Added description support for migrations

@tommarien tommarien merged commit 5d29fd9 into fluentmigrator:master Dec 29, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment