New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for 20170907 release. #372

Merged
merged 8 commits into from Sep 4, 2017

Conversation

Projects
None yet
5 participants
@thefallentree
Member

thefallentree commented Sep 4, 2017

No description provided.

@thefallentree thefallentree added this to the Fluffos-3.0-20170904 milestone Sep 4, 2017

@thefallentree thefallentree changed the title from Changes for 20170904 release. to Changes for 20170907 release. Sep 4, 2017

@thefallentree thefallentree merged commit 30bddae into master Sep 4, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@keeperofkeysAU

This comment has been minimized.

Show comment
Hide comment
@keeperofkeysAU

keeperofkeysAU Sep 4, 2017

Removing DWLIB for discworld mudlib support is an insult, I would really hope you plan on re-adding it

keeperofkeysAU commented Sep 4, 2017

Removing DWLIB for discworld mudlib support is an insult, I would really hope you plan on re-adding it

@thefallentree

This comment has been minimized.

Show comment
Hide comment
@thefallentree

thefallentree Sep 5, 2017

Member

@keeperofkeysAU please don't be so easily offended. No one is intended to insult anyone here.

DWLIB support is broken for almost 2 years now, and no one seems to care enough to fix it, that's the reason it is gone. The 3.0 driver codebase needs to be maintained, because it is actually still being used. (more than a lot of people would think here, apparently).

The open source rule is that if you care enough about it , just send a PR, if it passes the tests I am happy to include it.

Member

thefallentree commented Sep 5, 2017

@keeperofkeysAU please don't be so easily offended. No one is intended to insult anyone here.

DWLIB support is broken for almost 2 years now, and no one seems to care enough to fix it, that's the reason it is gone. The 3.0 driver codebase needs to be maintained, because it is actually still being used. (more than a lot of people would think here, apparently).

The open source rule is that if you care enough about it , just send a PR, if it passes the tests I am happy to include it.

@Shea690901

This comment has been minimized.

Show comment
Hide comment
@Shea690901

Shea690901 Sep 8, 2017

REVIEW (d6fb6db)

Why didn´t you wrote (src/packages/core/replace_program.cc):

if (name_len < 3 || name[name_len - 2] != '.' || name[name_len - 1] != 'c') {
     strcat(name, ".c");
   }

instead of

if (name_len < 3) {
    strcat(name, ".c");
} else {
   if (name[name_len - 2] != '.' || name[name_len - 1] != 'c') {
     strcat(name, ".c");
   }
}
``` ?

That way the code should be a little bit more compact even without optimization...

Shea690901 commented Sep 8, 2017

REVIEW (d6fb6db)

Why didn´t you wrote (src/packages/core/replace_program.cc):

if (name_len < 3 || name[name_len - 2] != '.' || name[name_len - 1] != 'c') {
     strcat(name, ".c");
   }

instead of

if (name_len < 3) {
    strcat(name, ".c");
} else {
   if (name[name_len - 2] != '.' || name[name_len - 1] != 'c') {
     strcat(name, ".c");
   }
}
``` ?

That way the code should be a little bit more compact even without optimization...
@quixadhal

This comment has been minimized.

Show comment
Hide comment
@quixadhal

quixadhal Sep 8, 2017

Member
Member

quixadhal commented Sep 8, 2017

@thefallentree

This comment has been minimized.

Show comment
Hide comment
@thefallentree

thefallentree Sep 8, 2017

Member
Member

thefallentree commented Sep 8, 2017

@quixadhal

This comment has been minimized.

Show comment
Hide comment
@quixadhal

quixadhal Sep 8, 2017

Member
Member

quixadhal commented Sep 8, 2017

@cartercheng

This comment has been minimized.

Show comment
Hide comment
@cartercheng

cartercheng Sep 9, 2017

I think that perhaps not such a good idea to take out these two packages over fixing them. I suspect the debug stuff is used by quite a few people. As for dwlib, I actually hate to see this go too.

cartercheng commented Sep 9, 2017

I think that perhaps not such a good idea to take out these two packages over fixing them. I suspect the debug stuff is used by quite a few people. As for dwlib, I actually hate to see this go too.

@thefallentree

This comment has been minimized.

Show comment
Hide comment
@thefallentree

thefallentree Sep 9, 2017

Member
Member

thefallentree commented Sep 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment