New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onMainVideoEnded event to always fire #157

Merged
merged 3 commits into from May 21, 2018

Conversation

Projects
None yet
3 participants
@cian-exads
Collaborator

cian-exads commented May 15, 2018

No description provided.

@gibigate

This comment has been minimized.

Contributor

gibigate commented May 17, 2018

onMainVideoEnded event fire when blank.mp4 video ended on safari

Temporary fix:
onMainVideoEnded: function () {
if(this.src.indexOf('blank.mp4') >= 0) {
return;
}
....

@cian-exads

This comment has been minimized.

Collaborator

cian-exads commented May 17, 2018

@gibigate what version of safari on what device? I'm unable to reproduce on Mac, iPhone or iPad for that issue.

@gibigate

This comment has been minimized.

Contributor

gibigate commented May 18, 2018

Ipad mini, ios 11.2.6, safari 11.0

@cian-exads

This comment has been minimized.

Collaborator

cian-exads commented May 18, 2018

Thanks @gibigate, was able to reproduce it and I've added in a fix for the blank.mp4 under this PR. Thanks again!

@golikov golikov changed the base branch from master to release_candidate May 21, 2018

@golikov golikov merged commit 588778c into release_candidate May 21, 2018

@golikov golikov deleted the ESR-2557 branch May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment