Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Design for Privacy entry #15

Merged
merged 2 commits into from Jun 18, 2018

Conversation

Projects
None yet
3 participants
@sepidehshahi
Copy link
Contributor

commented Jun 4, 2018

This is the 'Design for Privacy' entry for ILDH.

@CLAassistant

This comment has been minimized.

Copy link

commented Jun 4, 2018

CLA assistant check
All committers have signed the CLA.

@jhung
Copy link
Member

left a comment

Please see the 3 comments.

---
title: Design for Privacy
layout: default
category: Methods

This comment has been minimized.

Copy link
@jhung

jhung Jun 13, 2018

Member

Methods is no longer a category. This should be category: Approaches.

</figcaption>
</figure>

Image courtesy of [Designboom](https://www.designboom.com/readers/dima-yarovinsky-visualizes-facebook-instagram-snapchat-terms-of-service-05-07-2018/)

This comment has been minimized.

Copy link
@jhung

jhung Jun 13, 2018

Member

I think this line "Image courtesy..." should appear inside the <figcaption> element. Currently it looks out of context when viewed.


<figure>
<a name="Figure4"></a>
[![Figure 4. Story builder tool - privacy options screenshots”]({{{getRelativeUrl '/images/PrivacyInternetUse.png' document.url}}})]({{{getRelativeUrl '/images/PrivacyInternetUse.png' document.url}}})

This comment has been minimized.

Copy link
@jhung

jhung Jun 13, 2018

Member

Image 3 and 4 are the same. It appears Image 3 is incorrect?

@sepidehshahi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2018

Hi @jhung, I have made the changes. You can go ahead and merge it. Thanks

@jhung

jhung approved these changes Jun 18, 2018

@jhung jhung merged commit 10a20d1 into fluid-project:master Jun 18, 2018

1 check passed

license/cla Contributor License Agreement is signed.
Details

gtirloni added a commit that referenced this pull request Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.