Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLUID-6015: Refactoring, and improvements for mobile #7

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@jhung
Copy link
Member

jhung commented Dec 19, 2016

Refactoring and clean-up of docs-template.

  • upgrade to Foundation 6 for sites
  • now uses npm to install infusion and Foundation
  • now uses Grunt to build and lint
  • removed dependency to docs-core. Refactored docs-core helpers to helpers-docpad
  • Refactored template blocks into partials
  • Styling improvements and refactoring, specifically improved the behaviour of the topics sidebar for desktop and mobile.

@jobara can you review?

jhung added some commits Dec 10, 2016

FLUID-6015: Refactoring and restyling
Refactoring and restyling docs-template
* upgrade to Foundation 6 for sites
* now uses npm to install infusion and Foundation
* now uses Grunt to build and lint
* removed dependency to docs-core. Refactored docs-core helpers to
helpers-docpad
* Refactored template blocks into partials
* Styling improvements and refactoring, specifically improved the
behaviour of the topics sidebar for desktop and mobile.
FLUID-6015: Refactoring and clean-up
- Added aria-expanded attribute to sidebar
- Moved Stylus files intended for @import into includes directory
- added a docpad configuration to stop stylus files from being pushed
to the output directory.
- comments, and cleanup.

@jhung jhung requested a review from jobara Dec 19, 2016

@jhung

This comment has been minimized.

Copy link
Member Author

jhung commented Dec 19, 2016

Just noticed the conflicts. I'll look into this.

@jhung

This comment has been minimized.

Copy link
Member Author

jhung commented Dec 21, 2016

Resolved conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.