Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed CNAME file #141

Merged
merged 1 commit into from Mar 11, 2020
Merged

Conversation

sachin10101998
Copy link
Contributor

No need to keep the CNAME file since the website is not hosted using gh-pages. Therefore, the file for a custom domain is not required.

@sachin10101998
Copy link
Contributor Author

@jobara views?

@jobara
Copy link
Member

jobara commented Mar 11, 2020

@waharnum thoughts on this? Does the CNAME file get used for anything in our current hosting setup?

@waharnum
Copy link
Member

waharnum commented Mar 11, 2020

@waharnum thoughts on this? Does the CNAME file get used for anything in our current hosting setup?

There's no need to retain the CNAME file.

@jobara jobara merged commit b45fd1e into fluid-project:master Mar 11, 2020
@jobara
Copy link
Member

jobara commented Mar 11, 2020

merged at b45fd1e

@sachin10101998 sachin10101998 deleted the RemoveCNAME branch March 19, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants