Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
FLUID-5722: Add search component. #147
Adds search functionality based on Fuse.js. See FLUID-5722 for details.
Rather than commit a copy of another dependency, I converted nearly all dependencies to proper npm dependencies that are copied to the output in the "writeAfter" stage. The only dependency I could not clean up is the forked and modified highlight.js CSS, which is older than their packaged versioning available via npm.
@amb26, the new search has been manually tested in Safari, Opera, Chrome, Firefox, IE 11, and Edge.
There were some small problems in pinning to a non-global docpad in Windows, I had to avoid using npm run directly on the docpad binary, but the new dependency management, etc. is verified working in a Windows VM as well.
referenced this pull request
Apr 30, 2019
For this pass, we discussed adding gpii-binder and gpii-location-bar so that searches are navigable (back button) and persistable (bookmarking, copying, etc.). We also discussed adding _target attributes to search hit links.
Unfortunately the "deploy" script doesn't seem to run (any more), although I suspect this is not the result of work in this branch. The failure occurs within the plugin during the actions
which then causes git to complain
Perhaps the script needs to have cwd set correctly or some such shiznitz.