FLUID-4681: Trial version of improved "dead man's blur" #215
Conversation
…s a facade API to "globalDismissal" strategy rescued from CSpace, for resolving failure of blur detection when using TinyMCE version 3.4.8. New implementation and tests for fluid.keys and fluid.values
|
Just gave it a go an works like a dream. I have marked the nessessary files so that once a long term fix is found, I can upgrade easily. Once again thanks :) |
… instances are created per page. This caused failed registration of listeners since the 2nd instance has its markup created synchronously. Resolved a further issue where "globalDismissal" only kept one dismissal entry as a result of both registered containers supplying the same id "tinymce" created by the renderer within the iframe.
|
TinyMCE version has been removed from framework image and the demo updated to use an updated reference from our CDN. This is now a serious pull request |
|
I noticed an issue with TinyMCE. When you use the bold or italic buttons the rich text editor closes. |
… font links discovered during review
|
I tested your fix and the buttons all work now. I'm still seeing the issue of the editor closing when using the drop down to change the format from 'paragraph' to 'heading'. |
…controls which are appended to the overall document body
|
This is a particularly appalling problem since TinyMCE dynamically creates DOM material for dropdowns which is pushed to the end of the document and is floated on top of its UI using absolute CSS positioning (much like a tooltip). I added "by inspection" a bunch of event registration that works with the current TinyMCE in order to intercept the creation of the dropdown to add it to the list of DMB "exclusions" but this uses completely undocumented features of the TinyMCE API. |
|
Merged into project repo at 88390cc |
FLUID-4681: Trial version of improved "dead man's blur" which provides a facade API to "globalDismissal" strategy rescued from CSpace, for resolving failure of blur detection when using TinyMCE version 3.4.8. New implementation and tests for fluid.keys and fluid.values
This isn't a serious request for a pull yet since there are several obvious issues with the implementation, but a request for review and testing. Before this can be pulled back in, we need to
i) Strip back out the version of TinyMCE I have committed for testing, and put it up into our CDN with the others,
ii) Get design input on whether the inconsistency of the behaviour of this component with the simple InlineEdit (that it cancels an edit on blur, rather than committing it) is really correct, and also what the correct behaviour should be on receiving a focus outside the component other than on click
iii) Determine whether the new "facade API" for deadMansBlur is really reasonable given its "stateful model" for its lifetime using the "reArm", "proceed" etc. methods which were not used by the previous stateless system which did not defer to globalDismissal.