Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLUID-6148: Implement "potentia II" constituting aligned, transactional records of author's creational intent #824

Open
wants to merge 50 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@amb26
Copy link
Member

amb26 commented Mar 28, 2017

This branch is complete and ready to review. It resolves the following issues:

https://issues.fluidproject.org/browse/FLUID-6146 Mutual reference between createOnEvent components
https://issues.fluidproject.org/browse/FLUID-6147 Transactional units for component creation
https://issues.fluidproject.org/browse/FLUID-4925 "wave of explosions"
https://issues.fluidproject.org/browse/FLUID-5519 Problematic timing of model init transaction
https://issues.fluidproject.org/browse/FLUID-6145 Make component options immutable
https://issues.fluidproject.org/browse/FLUID-5614 "double deep trees"

amb26 added some commits Mar 28, 2017

FLUID-6148: First "smoke test ready" version which passes linting and…
… Fluid.js tests with component creators removed
FLUID-6148: Fully repaired all existing FluidIoC.js tests with the ex…
…ception of FLUID-5696 test which operates model system
Merge branch 'master' into FLUID-6148
* master: (220 commits)
  FLUID-6213: Remove corruption when instantiating dynamic component with directly specified subcomponents
  FLUID-6202: Anti-Zalgoisation in fluid.fetchResources to avoid construction races in event binding code
  FLUID-6202: Non-failing test for wrong diagnosis of cause of issue
  FLUID-5534: Updating so that the tests will pass after an npm install.
  FLUID-5534: Updating namespace for separated panel tests.
  FLUID-5534: Adding comment about requiring two iframes in test.
  FLUID-5534: Improving namespace for responsive tests.
  FLUID-5534: Simplifying model by using panelIndex directly in transform
  FLUID-6196: Passing reference to paths around instead
  FLUID-5534: Fixed bug in triggerDOMEvent function
  FLUID-5534: Using sequence injection to setup tests.
  FLUID-5534: Fixing event dispatch for IE11
  FLUID-5534: Adding iframe setup to tests. Now run in all-tests.
  FLUID-6195: Catch block in deenlistModelComponent to prevent permanent framework corruption through exploding relay rule
  FLUID-5534: Added a test for the window resize event.
  FLUID-6194: Removed now unnecessary commented guard - the inverse of a transform may flip from existing to nonexisting as it is edited (implausible, but in theory possible with the current architecture)
  FLUID-6194: Avoid relaying DELETEs backwards for transformations which do not have inverses
  FLUID-6192: Updating copyright years following review
  FLUID-5534: removing window even onDestroy
  FLUID-5534: Uncommenting the beforeReset event defintion
  ...
FLUID-6148: All existing test cases repaired!
Merge branch 'master' into FLUID-6148
FLUID-6148: Tidy-up following self-review, and first dedicated test -…
… construct circularly referent components on event
@the-t-in-rtf

This comment has been minimized.

Copy link
Contributor

the-t-in-rtf commented Mar 5, 2018

I worked my way up through gpii-launcher and gpii-testem, and cut dev releases of both. Here's the latest gpii-testem, which includes a newer launcher:

2.0.1-dev.20180305T122415Z.5c5b279

That should be "new enough turtles all the way down".

amb26 added some commits Mar 5, 2018

Merged up with JSDocs branch, further additions of documentation
Implemented "workflow functions"
Merge branch 'master' into FLUID-6148
@jobara

This comment has been minimized.

Copy link
Member

jobara commented May 22, 2018

@simonbates would you be able to review this PR

@jobara jobara requested a review from simonbates May 22, 2018

@incd-ci-robot

This comment has been minimized.

FLUID-6148: Fixes following "cancellation of mixed creation and destr…
…uction" problem found testing with GPII
@incd-ci-robot

This comment has been minimized.

@incd-ci-robot

This comment has been minimized.

@incd-ci-robot

This comment has been minimized.

@incd-ci-robot

This comment has been minimized.

@incd-ci-robot

This comment has been minimized.

@incd-ci-robot

This comment has been minimized.

@incd-ci-robot

This comment has been minimized.

@incd-ci-robot

This comment has been minimized.

FLUID-6148: Stabilised test cases once more after rewrite of fluid.fe…
…tchResources and fluid.resourceLoader - split workflow of modelComponents and beginnings of resource triggering within IoC. Next stage is to dismantle component instantiation into promise sequence, big shame since it looked nice and compact and was easy to follow in the debugger.
@incd-ci-robot

This comment has been minimized.

@incd-ci-robot

This comment has been minimized.

@incd-ci-robot

This comment has been minimized.

FLUID-4982: Valid construction of asynchronous free components with o…
…verlapped I/O, and working failure idiom
@incd-ci-robot

This comment has been minimized.

@incd-ci-robot

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.