Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLUID-6297: Adding low contrast themes #915

Merged
merged 6 commits into from Jul 31, 2018

Conversation

Projects
None yet
2 participants
@jobara
Copy link
Member

commented Jul 24, 2018

Added two more low contrast themes: black on brown, grey on white.

https://issues.fluidproject.org/browse/FLUID-6297

});
};

demo.injectSVG.inject = function (that, svgMarkup) {

This comment has been minimized.

Copy link
@amb26

amb26 Jul 26, 2018

Member

It looks like this could productively be added to the NewViewSupport.js that was added as part of the orator work. Note that there is a work-alike in https://github.com/fluid-project/fluid-authoring/blob/FLUID-4884/src/js/ComponentGraph.js#L567 - it is worth investigating whether these achieve the same effect, or whether this approach might even allow us to do without a wrapper. In any case we should move this component over to https://github.com/fluid-project/infusion/blob/master/src/framework/core/js/ResourceLoader.js#L27 which would eliminate a lot of boilerplate.

@jobara

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2018

@amb26 I added a new view support that renders a fetched template. This PR is ready for another round of review.

@amb26 amb26 merged commit 2ba19ee into fluid-project:master Jul 31, 2018

8 checks passed

buildkite/infusion Build #346 passed (17 minutes, 23 seconds)
Details
buildkite/infusion/browser-tests Passed (8 minutes, 5 seconds)
Details
buildkite/infusion/build Passed (8 minutes, 15 seconds)
Details
buildkite/infusion/cleanup Passed (7 seconds)
Details
buildkite/infusion/code-linter Passed (16 seconds)
Details
buildkite/infusion/node-tests Passed (23 seconds)
Details
buildkite/infusion/pipeline Passed (8 seconds)
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.