Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLUID-6253: Retrieving dependencies from NPM #929

Closed
wants to merge 20 commits into from

Conversation

Projects
None yet
3 participants
@jobara
Copy link
Member

commented Aug 30, 2018

Pulls in dependencies available on NPM from there. Dependencies that do not have an appropriate NPM package are left in place. For the dependencies that come from NPM the are copied over to the correct lib directory with a post install task, or by calling grunt loadDependencies.

https://issues.fluidproject.org/browse/FLUID-6253

Requires: fluid-project/grunt-modulefiles#7
Doc PR: fluid-project/infusion-docs#141

jobara added some commits Aug 22, 2018

FLUID-6253: Removed Foundation Lib.
Foundation was mostly being used for centering content. This has been 
replaced by some simple CSS that is shared between the demos.

Also updated most of the demos to be mobile responsive. However, a few 
of the demos are still desktop presentation only (prefs framework, 
layout reorderer, uploader).
FLUID-6253: Pulling in jQuery from NPM.
Didn't yet update jQuery because of a failing unit test in tooltip. 
Possibly due to changes with effects in jQuery 3.2.0.
FLUID-6253: Updated to the latest jQuery. Fixed tooltip test that was…
… failing due to changes in jQuery's effects.
FLUID-6253: Pulling in jquery ui from NPM.
jQuery UI's npm package does not inlclude a concatenated file. Instead 
pulling in only the individual files that we use. These will be 
concantenated with our build process, but are used individually in the 
demos, tests, and etc.

Will look at pulling in the jQuery UI CSS in a future commit.
@incd-ci-robot

This comment has been minimized.

Copy link

commented Aug 30, 2018

Could one of the admins verify that these changes are reasonable to test? If so, please reply with "ok to test".

@jobara

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2018

ok to test

1 similar comment
@jobara

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2018

ok to test

@incd-ci-robot

This comment has been minimized.

@amb26

This comment has been minimized.

Copy link
Member

commented Sep 14, 2018

Closed for #934

@amb26 amb26 closed this Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.