Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLUID-6257: Successful writes update remote model path from local model path #933

Merged
merged 6 commits into from Sep 21, 2018

Conversation

@jobara
Copy link
Member

commented Sep 13, 2018

Removes the temporary fix, and now requires that writes resolve/reject its promise after the write operation has been handled and not simply after the request has been sent.

https://issues.fluidproject.org/browse/FLUID-6257

@jobara

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2018

@amb26 or @cindyli would you be able to review this PR

@incd-ci-robot

This comment has been minimized.

@@ -68,9 +68,14 @@ var fluid_3_0_0 = fluid_3_0_0 || {};
listener: "fluid.remoteModelComponent.unblockFetchReq",
args: ["{that}"]
},
"afterWrite.updateRemoteModel": {
changePath: "remote",
value: "{that}.model.local"

This comment has been minimized.

Copy link
@amb26

amb26 Sep 14, 2018

Member

Seems awkward - what if the change included a DELETE?

@incd-ci-robot

This comment has been minimized.

In a single transaction will delete the existing remote model path and 
replace it with the contents of the local model path, after a successful 
write.
@incd-ci-robot

This comment has been minimized.

@jobara

This comment has been minimized.

Copy link
Member Author

commented Sep 17, 2018

@amb26 I've addressed your comment. The remote model path is now deleted and set to the value of the local model path in a single transaction. This PR is ready for more review.

@incd-ci-robot

This comment has been minimized.

@incd-ci-robot

This comment has been minimized.

@amb26 amb26 merged commit d6698a6 into fluid-project:master Sep 21, 2018
2 checks passed
2 checks passed
jenkins Build finished.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.