Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLUID-6318: Updating the selection reader control to play and stop. #945

Merged
merged 3 commits into from Nov 27, 2018

Conversation

Projects
None yet
3 participants
@@ -847,6 +856,10 @@ var fluid_3_0_0 = fluid_3_0_0 || {};
stop: {
funcName: "fluid.orator.selectionReader.stopSpeech",
args: ["{that}.model.play", "{fluid.textToSpeech}.cancel"]
},
toggle: {
funcName: "fluid.orator.selectionReader.togglePlay",

This comment has been minimized.

Copy link
@cindyli

cindyli Nov 27, 2018

Member

Understand the state argument is implicitly passed in via jQuery click event. But it would be more readable and reusable to include the pass-in of {arguments}.0 on the argument list.

The same comment applies to the other toggle() function at line 161.

@jobara

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2018

@cindyli I've addressed your comment. Ready for more review.

@incd-ci-robot

This comment has been minimized.

@incd-ci-robot

This comment has been minimized.

@cindyli cindyli merged commit 0ef880d into fluid-project:master Nov 27, 2018

2 checks passed

jenkins Build finished.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.