Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLUID-6322, FLUID-6312, FLUID-5928: Aliased model paths, and ToC localization #950

Open
wants to merge 37 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@jobara
Copy link
Member

commented Jan 20, 2019

Added localization for Table of Contents header. Also added the option to provide an alias, via the auxSchema, for having the preference copied to a known location.

https://issues.fluidproject.org/browse/FLUID-6322
https://issues.fluidproject.org/browse/FLUID-6312
https://issues.fluidproject.org/browse/FLUID-5928

This PR includes changes from #949

BlueSlug and others added some commits Sep 27, 2018

FLUID-6303: Updating localization panel and enactor.
Added example for localization change with URL path.
FLUID-6303: Removing localizated UIO demo.
Should add an example of dynamically localizing after FLUID-6300 is 
complete.
FLUID-5928, FLUID-6312: Adding an alias to the prefs type.
The alias can be used in the auxiliary schema to create a secondary 
model path to be used for the preference. The preference value is then 
accessible at both the alias and the modified pref type.
FLUID-6303: Addressing code review comments.
Largely around refactoring the example to make it easier to work with. 
This led to many refactorings in the implementation for the enactor and 
moving configuration for the constructed prefs editor into a shareable 
grade.
FLUID-6303: rolling back testem to v2.12.0
gpii-testem currently doesn't support beyond testem 2.12.0
FLUID-6303: Corrected some errors with LocalizationPrefsEditor config.
Including the addition of options distributions for the locale names to 
the stringArrayIndex to set the options for the panel.

jobara added some commits Jan 17, 2019

FLUID-6303: Refactoring based on "design crit" feedback.
Default is now called "No Preferences". 

Also refactored urlLangSeg into a model relay.
FLUID-5928, FLUID-6312: Fixed alias issues.
- Fixed model being droped on init.
- Fixed model relay bindings for enhancer
- Added tests
@jobara

This comment has been minimized.

Copy link
Member Author

commented Jan 20, 2019

@cindyli and @amb26 could you please review this PR. It also includes changes from #949

@incd-ci-robot

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.