Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLUID-6392: Only calling cancel when disabling. #959

Merged
merged 3 commits into from Aug 8, 2019

Conversation

@jobara
Copy link
Member

commented Aug 7, 2019

https://issues.fluidproject.org/browse/FLUID-6392

Needed to address https://issues.gpii.net/browse/GPII-3977. A dev release of Infusion has also been generated ( 3.0.0-dev.20190807T173919Z.741f09ead.FLUID-6392 ) for testing.

@jobara

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

@amb26 would you mind to review this PR?

@incd-ci-robot

This comment has been minimized.

@amb26

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Strange failure through "abort"...
ok 205 Chrome 76.0 - [1448 ms] - Framework Tests: /tests/framework-tests/preferences/html/SelfVoicingEnactor-test.html
Build was aborted
Aborted by unknown
Killed by signal 15.

@amb26

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

ok to test

@incd-ci-robot

This comment has been minimized.

@jobara jobara force-pushed the jobara:FLUID-6392 branch from 741f09e to c6ec29f Aug 8, 2019

@jobara jobara changed the title FLUID-6932: Only calling cancel when disabling. FLUID-6392: Only calling cancel when disabling. Aug 8, 2019

FLUID-6392: Added a TODO for cleaning up the function.
Will be able to remove the function when FLUID-6393 is complete.
@jobara

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

@amb26 ready for another round of review.

@jobara

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

Strange failure through "abort"...
ok 205 Chrome 76.0 - [1448 ms] - Framework Tests: /tests/framework-tests/preferences/html/SelfVoicingEnactor-test.html
Build was aborted
Aborted by unknown
Killed by signal 15.

Could it be related to https://issues.fluidproject.org/browse/FLUID-6385? Although I haven't personally seen this issue trigger anywhere but the current version of MS Edge.

Actually this might just be the issue that #958 is addressing.

@incd-ci-robot

This comment has been minimized.

@incd-ci-robot

This comment has been minimized.

@jobara

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

ok to test

@incd-ci-robot

This comment has been minimized.

@incd-ci-robot

This comment has been minimized.

@amb26 amb26 merged commit 470d205 into fluid-project:master Aug 8, 2019

2 checks passed

jenkins Build finished.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.