Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLUID-6394: Addressing positioning of TTS selection reader control #960

Merged
merged 3 commits into from Sep 5, 2019

Conversation

@jobara
Copy link
Member

commented Aug 14, 2019

Taking into consideration margin of container when positioning TTS selection reader control.

https://issues.fluidproject.org/browse/FLUID-6394

dev release for testing: 3.0.0-dev.20190820T145526Z.389bd6937.FLUID-6394

Needed for https://issues.gpii.net/browse/GPII-3767

@jobara

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

@amb26 or @cindyli are you able to review this PR?

@incd-ci-robot

This comment has been minimized.

@cindyli

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

This fix does offer a better user experience. Here are a few other issues I noticed:

  1. Issues with selecting the top line on the webpage:
  • When dragging mouse from right to left to select the top line text, the display of "Play" button covers some of the selected text:

image

  • When dragging mouse from left to right to select the top line text, the display of "Play" button shows much ahead of the start of the selected text (this might because the Morphic logo image is considered as selected so the button is displayed there):

image

  1. When a chunk of text is selected, the "play" button is displayed closed to the first line of selected text. When continuing to drag the mouse to select more text, or stop dragging but scroll the page to see the content below, "play" button stays at where it was rendered and disappears from the view. It would be nice to keep the "play" button always showing in the viewport but this might be an extra feature.

image

@jobara

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

@cindyli thanks for your feedback. Below is my response to your points above.

  1. Selecting top line
    a. will need to investigate. Probably something to do with collision detection with the top of the screen.
    b. the location of the play button is based off of where selected range indicates is the start position. I don't think we can adjust this without modifying the users selection, which may not be what the user wants.
  2. We could really do either or, but I find it becomes very confusing when the play button starts moving around. That can still happen in some cases. You can see that with the overview panel in our demos because it is fixed positioned. Maybe a question for a design crit?
@jobara

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

@cindyli ready for more review. There was a small regression with the positioning when the play button should have been below. I've updated the info in the comment with the latest dev release for testing in UIO+.

@incd-ci-robot

This comment has been minimized.

@cindyli cindyli merged commit 389bd69 into fluid-project:master Sep 5, 2019

2 checks passed

jenkins Build finished.
Details
license/cla Contributor License Agreement is signed.
Details
@cindyli

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

Merged at b024bff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.