Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFLUID-6422: Refactoring fluid.textNodeParser.hasTextToRead #966
Conversation
- combined with fluid.textNodeParser.hasVisibleText - improvents to algorithm for ignoring non-rendered text
This comment has been minimized.
This comment has been minimized.
|
@cindyli would you be able to review this PR? |
This comment has been minimized.
This comment has been minimized.
incd-ci-robot
commented
Nov 4, 2019
|
CI job failed: https://ci.fluidproject.org/job/infusion-pull-request/269/ |
This comment has been minimized.
This comment has been minimized.
|
ok to test |
This comment has been minimized.
This comment has been minimized.
incd-ci-robot
commented
Nov 5, 2019
|
CI job passed: https://ci.fluidproject.org/job/infusion-pull-request/270/ |
This comment has been minimized.
This comment has been minimized.
|
Merged at ff0a355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jobara commentedNov 4, 2019
•
edited
Dev release to test with UIO+: 3.0.0-dev.20191104T213827Z.4f3dd87a8.FLUID-6422-UIO-Plus-Build (has merged FLUID-6148 branch)
https://issues.fluidproject.org/browse/FLUID-6422