Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLUID-6422: Refactoring fluid.textNodeParser.hasTextToRead #966

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@jobara
Copy link
Member

jobara commented Nov 4, 2019

  • combined with fluid.textNodeParser.hasVisibleText
  • improvements to algorithm for ignoring non-rendered text

Dev release to test with UIO+: 3.0.0-dev.20191104T213827Z.4f3dd87a8.FLUID-6422-UIO-Plus-Build (has merged FLUID-6148 branch)

https://issues.fluidproject.org/browse/FLUID-6422

- combined with fluid.textNodeParser.hasVisibleText
- improvents to algorithm for ignoring non-rendered text
@jobara

This comment has been minimized.

Copy link
Member Author

jobara commented Nov 4, 2019

@cindyli would you be able to review this PR?

@incd-ci-robot

This comment has been minimized.

@cindyli

This comment has been minimized.

Copy link
Member

cindyli commented Nov 5, 2019

ok to test

@incd-ci-robot

This comment has been minimized.

@cindyli cindyli merged commit 7a64425 into fluid-project:master Nov 6, 2019
2 checks passed
2 checks passed
jenkins Build finished.
Details
license/cla Contributor License Agreement is signed.
Details
@cindyli

This comment has been minimized.

Copy link
Member

cindyli commented Nov 6, 2019

Merged at ff0a355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.