SJRK-435: fix ToC preview bug #104
Conversation
| .flc-toc-tocContainer { | ||
| display: none !important; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
Rather than adding a <style> element, it may be cleared just to add an it as an inline style directly on toc container. It would also be good to leave a comment with a link to the JIRA to explain why it's hidden.
There was a problem hiding this comment.
I had tried this, since inline styling has the highest specificity, but turning the TOC preference on and off will make the element show again.
|
Rather than revert the commit, could you reset back and only include the change to the styling. It would also be good to update the JIRA with some information about approaches tried and the why the current solution was chosen. Just so we can keep a history of things. |
|
I've added this comment to the Jira, detailing why the particular solution we chose is used and what other options were considered. Ready for more review :) |
jobara
changed the title
|
merged at c52e54e |
UPDATE: This bug is solved by always hiding the UIO Table of Contents on the Edit page
Jira: https://issues.fluidproject.org/browse/SJRK-435