Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SJRK-227: Added logging invoker and listeners for all datasource.onError #22

Merged
merged 3 commits into from Apr 25, 2019

Conversation

Projects
None yet
2 participants
@BlueSlug
Copy link
Member

commented Apr 10, 2019

This pull request does not include integration tests as I was unable to determine how to listen for the fluid.loggingEvent being fired once fluid.log was called from the test server.

@cindyli

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Why not directly add the error handler to the base data source component sjrk.storyTelling.server.dataSource.couch.base?

@BlueSlug

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

@cindyli a great suggestion :) I've implemented it and everything seems to be working the same. The error messages are slightly less detailed, now, but the key info is there (in this case, the webserver is unable to connect to the couch server)

Show resolved Hide resolved server/src/js/dataSource.js Outdated

@cindyli cindyli merged commit b2128a0 into fluid-project:stories-floe-dev Apr 25, 2019

1 check passed

license/cla Contributor License Agreement is signed.
Details
@cindyli

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

Merged at 9448cb4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.