Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SJRK-255 - re-review pull to highlight suggestions for refactoring #35

Open
wants to merge 1,335 commits into
base: re-review
from

Conversation

@amb26
Copy link
Member

amb26 commented Aug 5, 2019

No description provided.

BlueSlug and others added 30 commits May 10, 2019
* gregor/SJRK-229:
  SJRK-229: requiredValues -> blockContentValues, updated comments
- body and header/footer colours are reversed
- new content
- added introduction page, messages
- reorganized LR grade structure a little
- moved browse/edit pages to header
* gregor/SJRK-246: (27 commits)
  SJRK-246: tidied up distribute options blocks to remove duplication
  SJRK-246: disabling editing ahead of push to production branch
  SJRK-246: updates to footer responsive styling
  SJRK-246: CSS bug fixes related to UIO contrast themes
  SJRK-246: fixed bug introduced by deactivating LR theme menu template
  SJRK-246: tidied up learningReflections grades w/ options distribution
  SJRK-246: removed cruft and fixed CSS colour issue
  SJRK-246: updates to top nav menu styling
  SJRK-246: added editor instructions and "sandbox mode" notice
  SJRK-246: added the "story builder" title and accent box to editor pages
  SJRK-246: updated "Explore Tool" to point explicitly to the edit page
  SJRK-246: major styling updates, separated LR templates, etc
  SJRK-246: styling updates, updated Workshops and Resources content
  SJRK-246: updated Browse page (somewhat merged both themes, will undo)
  SJRK-246: finished adding Workshops content, added Resources page & copy
  SJRK-246: header styling updates and padding adjustments
  SJRK-246: began implementing new design, font change, styling overhauled
  SJRK-246: added Workshops page, made LR menu consistent across all pages
  SJRK-246: more styling changes
  SJRK-246: updates to intro buttons and responsive grid columns
  ...
* stories-floe-dev: (46 commits)
  SJRK-246: tidied up distribute options blocks to remove duplication
  SJRK-246: disabling editing ahead of push to production branch
  SJRK-246: updates to footer responsive styling
  SJRK-246: CSS bug fixes related to UIO contrast themes
  SJRK-246: fixed bug introduced by deactivating LR theme menu template
  SJRK-246: tidied up learningReflections grades w/ options distribution
  SJRK-246: removed cruft and fixed CSS colour issue
  SJRK-246: updates to top nav menu styling
  SJRK-246: added editor instructions and "sandbox mode" notice
  SJRK-246: added the "story builder" title and accent box to editor pages
  SJRK-246: updated "Explore Tool" to point explicitly to the edit page
  SJRK-246: major styling updates, separated LR templates, etc
  SJRK-246: styling updates, updated Workshops and Resources content
  SJRK-246: updated Browse page (somewhat merged both themes, will undo)
  SJRK-246: finished adding Workshops content, added Resources page & copy
  SJRK-246: header styling updates and padding adjustments
  SJRK-246: began implementing new design, font change, styling overhauled
  SJRK-246: added Workshops page, made LR menu consistent across all pages
  SJRK-246: more styling changes
  SJRK-246: updates to intro buttons and responsive grid columns
  ...
BlueSlug and others added 29 commits Nov 15, 2019
* ned/SJRK-292:
  Uppercase LIST and GRID, remove CSS text-transform for these controls
  Migrate remaining colons into messages
  Move 'Contains:' colon into messages
  Remove colon from template rather than message
  SJRK-292: Remove extraneous comma from story browse page
…buteOptions blocks on the same option value.
SJRK-297: Fix the race condition resulted from having multiple distributeOptions blocks on the same option value
* gregor/SJRK-297:
  SJRK-297: removed extraneous `else` in handlebars markup
  SJRK-297: Fix the race condition resulted from having multiple distributeOptions blocks on the same option value.
  SJRK-297: `sojustrepairit` theme Edit link now based on authoring flag
  SJRK-297: removing edit page links since story gathering is complete
* gregor/SJRK-286:
  SJRK-286: improved rotateImageFromExif tests and removed race condition
  SJRK-286: improved image rotation tests and added explanatory comments
  SJRK-286: updated manual test file link to match new filename
  SJRK-286: updated test image files with more meaningful names
  SJRK-286: refactored image rotation promises, updated associated tests
  SJRK-286: added another call to clear the test uploads directory
  SJRK-286: converted unit tests to IoC fixtures instead of jqUnit calls
  SJRK-286: added integration test for image rotation on story save
  SJRK-286: added unit tests for saveStoryToDatabase function
  SJRK-286: refactored and added tests for buildBinaryRenameMap function
  SJRK-286: added unit tests for rotateImageFromExif function
  SJRK-286: added some initial server tests and updated .gitignore file
  SJRK-286: refactored `handleSaveStoryWithBinaries` to help create tests
  SJRK-286: fixed bug in image preview, updated manual image editor tests
  SJRK-286: added client-side image orientation fix, keeping server side
  SJRK-286: linting
  SJRK-286: added EXIF-based image rotation upon saving to server
cruft includes:
- languageFromSelect and languageFromInput values
- contentString model relays
- tests for contentString values and test files which consisted entirely 
of such tests
- the "restore block" button and css rules
- unused images
- unnecesary values for the example story
- localized messages which are no longer used
- anything else I may have missed
- moved multilingualSettings values to model
- removed `reloadUioMessages` function and calls
- gave names to some options distribution entries
- got TOC enactor to load **sometimes**, there is an as-yet unsolved 
race condition
- removed local copies of UIO l10n messages as they're no longer 
necessary
}
}
},
"relayOnCreateToc": {

This comment has been minimized.

Copy link
@cindyli

cindyli Dec 13, 2019

Member

"onCreateTOC" should be fired when "{messageLoader}.events.onResourcesLoaded" is fired.

But this doesn't solve the problem that the toc header is showing "[Object Object]" when the initial language is Spanish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.