Studio 50 #46

Merged
merged 16 commits into from Jun 19, 2012

Conversation

Projects
None yet
3 participants
Contributor

abledaccess commented May 8, 2012

Have at it. Here's hoping it's all settled. If it's not, please let me know. Thanks so much for all the help.

Owner

jobara commented May 10, 2012

@abledaccess looked this over with @cindyli today. For the most part, things look really good. I don't envy you having to work on IE. We had a couple of questions though. 1) Did you have a chance to look at the focus styling for IE7. Currently it's doesn't match the style of the theme.I'm assuming this has to do with the fact that IE7 may not support the Outline property. 2) There seems to be a lot of !important used in the IE8 specific css. It didn't seem like these were all necessary, and it does seem a bit odd that you would have to override some of the theme styles there. Do you know what is causing that?

Contributor

abledaccess commented May 10, 2012

I can look into all that, in a bit. I'll get back to you.

Contributor

abledaccess commented May 10, 2012

OK, Justin, I took out all the !important's from the ie8 specific style sheet and it didn't seem to affect anything. Good call. Thanks.

Owner

jobara commented May 10, 2012

Hi Johnny,

That's great. A bit of a warning. When Cindy and I played with it a bit today, the colour of the text on the Login button seemed to need the !importants for some reason. We may have missed another override, but you may want to test it with all of the themes just to be sure.

Thanks
Justin

On 2012-05-10, at 2:47 PM, Johnny Taylor wrote:

OK, Justin, I took out all the !important's from the ie8 specific style sheet and it didn't seem to affect anything. Good call. Thanks.


Reply to this email directly or view it on GitHub:
#46 (comment)

Contributor

abledaccess commented May 10, 2012

Just tested it and it seemed fine, however I put the !important's back on the login-out button, on all the theme's, just in case.

Owner

jobara commented May 10, 2012

Hi Johnny,

It would be nice if we didn't need those at all. It's strange that you didn't need those styles for the IE7 css file. I'm not sure if IE8 is doing something particularly funny. With IE it's pretty hard to rule that out :)

  • Justin

On 2012-05-10, at 3:10 PM, Johnny Taylor wrote:

Just tested it and it seemed fine, however I put the !important's back on the login-out button, on all the theme's, just in case.


Reply to this email directly or view it on GitHub:
#46 (comment)

Contributor

abledaccess commented May 10, 2012

The stranger thing is it's set up in a way so IE 8 styles correct the problems from the main style sheet and the IE 7 styles correct the styles inherited from 8. The fact 7 is doing anything independent of 8 is hilarious...

Contributor

abledaccess commented May 22, 2012

OK, as we discussed earlier, I resolved all the focusing issues in IE7. All but for the UIO button. I cannot find a fix anywhere! If you can, Justin, please let me know. When you can, of course. Thanks.

Owner

jobara commented May 25, 2012

@abledaccess You're right. It's pretty hard to find any info about fixing this focus issue in IE7. I've found couple of pages that might be useful to give you ideas on how to address it.

The first is about making buttons look like links. (Don't ask me why anyone would want to do that.) It's supposed to be cross browser compliant and does add keyboard focus back in. http://www.456bereastreet.com/archive/201110/styling_button_elements_to_look_like_links/

This second one is about removing the focus styling. Now, I'm not saying you should partake in any evils, but you might be able to manipulate the values to display the default focus better.
http://www.cssjunction.com/css/remove-black-border-around-input-buttons-in-ie-7/

Please let me know if any of those are helpful.

Owner

jobara commented Jun 7, 2012

@abledaccess I looked this over with @cindyli again. The IE7 focus issue looks fixed and it's all good. There were a few more things though. 1) when the Table of Contents is turned on and the text is large, when you shrink the width of the screen and the text spans multiple lines, the bullet goes to the bottom instead of to the top line. It looks like this is because of the display: inline-block 2) in IE7 when the Table of Contents, emphasize links, and comic sans are on, the text in the ToC is clipped at the bottom. The severity of this changes with the various text size settings, but we couldn't really see a pattern to it. 3) The IE 6 styles seem to have become broken. Not sure what's happened there.

Other than that, things are fine. We even tried it in the iPhone and iPad simulator and outside of some UIO issues, it looked great.

Contributor

abledaccess commented Jun 7, 2012

Justin, 1) I thought I fixed the table of contents list issue. Guess not. I'll get on it. 2) Huh. I got an idea how to fix that. Let me try. 3) I've never even looked at it in IE6. It wasn't broken before? I'm getting the impression this is a problem? We want support for IE6?

Owner

jobara commented Jun 7, 2012

@abledaccess I was thinking that you had already gotten it working in IE6 for some reason. I guess for now don't worry about it. We may come back to it later though

Contributor

abledaccess commented Jun 7, 2012

No sweat. I found some other problem while addressing the things you and Cindy found. Will this ever end?

Owner

jobara commented Jun 7, 2012

@abledaccess we're in the final stages now.. just polishing things up and making them all shiny.

Contributor

abledaccess commented Jun 7, 2012

Justin, I was kidding. I know. Don't worry.

Contributor

abledaccess commented Jun 7, 2012

Justin, OK, all solved. I set the ToC links to block, and aside from those links being active the whole width of the browser window, it fixed the bullet issue. And the cut off issue, with comic sans (too weird), seemed to be a line-height issue. I resolved it by bumping up the line-height, on that one element, in IE7, 20%. And it went away.

Now for the problem I found, it was an old issue, I remember fixing, just not why. I put in some :hover styles to address some behaviour. Seeing how it was on the small icons when the browser viewport is narrow, I suspect it was an IE9 issue. But I don't have IE9 installed on my machine, and I'm unable to reproduce what I thought the error was in IETester. Keep your eyes peeled.

Contributor

abledaccess commented Jun 17, 2012

Justin, sorry this has taken so long. In finding, and fixing, those errors I related to to you last week I discovered my fixes absolutely fixed the line-height in the ToC, despite using relative percentage units. I subsequently discovered any line-height applied to an element outside of body locked it at whatever value you set that element at in IE (7 and below). Meaning adjusting the UIOs line-height adjustment affected everything but the ToC.

Long story a bit shorter, to avoid the issues we were having with ToC, relating to line-height I mean — I fixed the list bullet behaviour — I had to set the body's line-height to 180% . Thing is I was unable to isolate the ToC, not even via the iframe's body class, and still have it respond to UIOS line-height slider.

Anyway have a look and let me know what you think. Thanks.

Owner

jobara commented Jun 18, 2012

@abledaccess it sounds like you are running into a bug with Infusion 1.4. If you switch to the other version of MyInfusion.js that you have in your repo you can probably remove your line-height settings and have things work properly in the regard again. Please let me know how that goes. Also if that works you can remove the old MyInfusion. If you still have the version.txt file that I sent you with the new MyInfusion could you add that beside the MyInfusion.js file.

Owner

jobara commented Jun 18, 2012

@abledaccess i was talking to @jameswy about the line-height. If the MyInfusion.js update doesn't solve the issue and you still need to explicitly set the line-height, then just leave the clipping issue and file a bug for it. The alternatives, large line-height everywhere or fixed line-height for the ToC seem to be worse.

Contributor

abledaccess commented Jun 18, 2012

OK, I'll fix it shortly. Thanks Justin.

@cindyli cindyli merged commit 83f4efd into fluid-project:development Jun 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment