fix(Outputs): static sort order #1745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical bug in the output pins sorting logic where the sort comparison function was incorrectly using only a single parameter instead of comparing two items.
Key changes:
- Fixed the
.sort()callback to properly compare two OutputPin objects instead of just evaluating one - Refactored getter calls into named constants for improved readability
- Proper sorting now places non-PWM pins before PWM pins, with alphabetical fallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was introduced with the changes on c1d24c3, caused by the fact that sort was only using a single item instead of a full comparison.
Fixes #1744