Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Z_Offset attempts to apply new values using the incorrect gcode command #546

Closed
samwiseg0 opened this issue Feb 28, 2022 · 0 comments · Fixed by #547
Closed

Save Z_Offset attempts to apply new values using the incorrect gcode command #546

samwiseg0 opened this issue Feb 28, 2022 · 0 comments · Fixed by #547
Assignees
Labels
GH - Bug Something isn't working
Milestone

Comments

@samwiseg0
Copy link
Contributor

samwiseg0 commented Feb 28, 2022

What happened

When saving the z offset from the UI, it attempts to apply new offset using the incorrect gcode command.

In this case my printer has both a z endstop and a probe. The probe is not used to home z instead the nozzle is on the z endstop.

In this scenario the new offset should be applied to the endstop and not probe.

Code:

get printerSettings () {
return this.$store.getters['printer/getPrinterSettings']()
}
get printerHasProbe (): boolean {
return 'probe' in this.printerSettings || 'bltouch' in this.printerSettings
}
handleZApplyDialog () {
let msg = this.$tc('app.general.simple_form.msg.apply_z_offset_endstop')
let gcode = 'Z_OFFSET_APPLY_ENDSTOP'
if (this.printerHasProbe) {
msg = this.$tc('app.general.simple_form.msg.apply_z_offset_probe')
gcode = 'Z_OFFSET_APPLY_PROBE'
}

What did you expect to happen

Fluidd should issue the correct gcode command to set the new z offset.

How to reproduce

  1. Configure klipper to have a z enstop and a probe.
  2. Attempt to save a new offset
  3. Observe that it issues Z_OFFSET_APPLY_PROBE instead of Z_OFFSET_APPLY_ENDSTOP

Additional information

More details were discussed in discord. They can be found here.
https://discord.com/channels/762863525818662974/771936287300911185/947836576480759828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GH - Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants