Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPILING.txt is slightly wrong #1

Open
kryton opened this issue Apr 7, 2011 · 5 comments
Open

COMPILING.txt is slightly wrong #1

kryton opened this issue Apr 7, 2011 · 5 comments
Assignees

Comments

@kryton
Copy link

kryton commented Apr 7, 2011

the instructions for building the thrift plugin didn't work for me.

all I needed to do was download the github version of the plugin, and do
$ mvn install

and changing the pom.xml to use 0.1.11-SNAPSHOT caused it to go past this.

also..thrift 0.5.0 isn't downloadable from thrift.apache.org, and the current version produces incompatible code :-(

@kimballa
Copy link
Member

kimballa commented Apr 8, 2011

Hi kryton,

How did the thrift plugin instructions break for you? In general I would prefer to not rely on SNAPSHOTs, because those can break arbitrarily in the future.

As for thrift itself: try http://incubator.apache.org/thrift/ -- not http://thrift.apache.org. They're similar looking, but I think the links work on the former and are broken on the latter.

@kimballa
Copy link
Member

kimballa commented Apr 8, 2011

Oh, interesting -- I just checked, thrift.apache.org has an even newer release available. I'll take a look at that over time. We should probably eventually move to 0.6.0. But in the meantime, 0.5.0 definitely works.

@kryton
Copy link
Author

kryton commented Apr 8, 2011

Hi Aaron.

  1. I couldn't find the plugin so I needed to build it.
    and I couldn't get this to work.

58 mvn install:install-file -Dfile=target/maven-thrift-plugin-0.1.10.jar
59 -DpomFile=./pom.xml -Dpackaging=maven-plugin -Dversion=0.1.10

a simple mvn install did though.
On Apr 8, 2011, at 11:26 AM, kimballa wrote:

Hi kryton,

How did the thrift plugin instructions break for you? In general I would prefer to not rely on SNAPSHOTs, because those can break arbitrarily in the future.

As for thrift itself: try http://incubator.apache.org/thrift/ -- not http://thrift.apache.org. They're similar looking, but I think the links work on the former and are broken on the latter.

Reply to this email directly or view it on GitHub:
#1 (comment)

Ian Holsman
Ian@Holsman.net
PH: +1-703 879-3128 AOLIM: ianholsman Skype:iholsman

“Live as if you were to die tomorrow. Learn as if you were to live forever.”
--Gandhi

@kimballa
Copy link
Member

It seems as though dtrott's maven-thrift-plugin master branch (the current 0.1.11-SNAPSHOT) doesn't actually work with Thrift 0.5.0. So we definitely shouldn't depend on this version :) (At least until FlumeBase migrates to thrift 0.6.)

So I force-pushed flumebase/maven-thrift-plugin's master branch to match the 0.1.10 release commit... and simplified COMPILING.txt.

If you checkout flumebase/maven-thrift-plugin, and run 'mvn clean package install' from there, can you then build without needing to depend on a snapshot release?

@ghost ghost assigned kimballa Apr 16, 2011
@kryton
Copy link
Author

kryton commented Apr 16, 2011

I'll try.
The plugin is quite simple to fix.
It's just switching -out to -o I think.


Ian Holsman - 703 879-3128

I saw the angel in the marble and carved until I set him free -- Michelangelo

On 15/04/2011, at 10:56 PM, kimballareply@reply.github.com wrote:

It seems as though dtrott's maven-thrift-plugin master branch (the current 0.1.11-SNAPSHOT) doesn't actually work with Thrift 0.5.0. So we definitely shouldn't depend on this version :) (At least until FlumeBase migrates to thrift 0.6.)

So I force-pushed flumebase/maven-thrift-plugin's master branch to match the 0.1.10 release commit... and simplified COMPILING.txt.

If you checkout flumebase/maven-thrift-plugin, and run 'mvn clean package install' from there, can you then build without needing to depend on a snapshot release?

Reply to this email directly or view it on GitHub:
#1 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants