New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to allow access to indexes before `ready` #22

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mmckegg

mmckegg commented Dec 5, 2018

This PR adds an awaitReady: false option to index reads by extending the wrap function to check options passed in.

Backlinks example:

ssb.backlinks.read({awaitReady: false, query}) // doesn't wait until indexes complete before starting

Not sure if this is the best way to solve the problem (a wee bit magical reading the opts like that), but having this feature is making a massive difference in my initial tests of Patchwork onboarding, so I'm keen to push to get something like this implemented!

cc @pietgeursen @dominictarr @ahdinosaur @arj03 @mixmix

mmckegg added a commit to ssbc/ssb-about that referenced this pull request Dec 5, 2018

mmckegg added a commit to ssbc/patchwork that referenced this pull request Dec 5, 2018

@mixmix

This comment has been minimized.

Contributor

mixmix commented Dec 5, 2018

@mmckegg

This comment has been minimized.

mmckegg commented Dec 5, 2018

Looks like this has been superseded by @dominictarr's #24 (with more options!!)

Closing.

@mmckegg mmckegg closed this Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment