From b018fd4e65470434821b4c3fd794b86caf345070 Mon Sep 17 00:00:00 2001 From: Swift Kim Date: Mon, 27 Sep 2021 14:22:40 +0900 Subject: [PATCH 1/3] Fix build for 2.5.1 --- azure-pipelines.yml | 2 ++ ci/docker/tizen/tools/build-engine.sh | 2 ++ 2 files changed, 4 insertions(+) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index d039c294953c8..503859e4aabbe 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -85,6 +85,8 @@ jobs: gclient sync -f -D sed -i 's/"-Wno-non-c-typedef-for-linkage",//g' build/config/compiler/BUILD.gn sed -i 's/"-Wno-psabi",//g' build/config/compiler/BUILD.gn + sed -i 's/"-Wno-unused-but-set-parameter",//g' build/config/compiler/BUILD.gn + sed -i 's/"-Wno-unused-but-set-variable",//g' build/config/compiler/BUILD.gn displayName: Disable build flags workingDirectory: $(Pipeline.Workspace)/src failOnStderr: true diff --git a/ci/docker/tizen/tools/build-engine.sh b/ci/docker/tizen/tools/build-engine.sh index d87793f9ddfc7..686529a6b8373 100755 --- a/ci/docker/tizen/tools/build-engine.sh +++ b/ci/docker/tizen/tools/build-engine.sh @@ -59,6 +59,8 @@ else # FIXME: Remove unsupported options of tizen toolchains from BUILD.gn. sed -i 's/"-Wno-non-c-typedef-for-linkage",//g' src/build/config/compiler/BUILD.gn sed -i 's/"-Wno-psabi",//g' src/build/config/compiler/BUILD.gn + sed -i 's/"-Wno-unused-but-set-parameter",//g' build/config/compiler/BUILD.gn + sed -i 's/"-Wno-unused-but-set-variable",//g' build/config/compiler/BUILD.gn src/flutter/tools/gn \ --target-os $BUILD_OS \ From ff0ce44c01afa01895d1bc091fb3023efb326875 Mon Sep 17 00:00:00 2001 From: Swift Kim Date: Mon, 27 Sep 2021 16:22:07 +0900 Subject: [PATCH 2/3] Fix runtime errors --- shell/platform/tizen/flutter_tizen_engine.cc | 2 +- shell/platform/tizen/touch_event_handler.cc | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/shell/platform/tizen/flutter_tizen_engine.cc b/shell/platform/tizen/flutter_tizen_engine.cc index 4d6b20c39a3dd..4727fafd5273d 100644 --- a/shell/platform/tizen/flutter_tizen_engine.cc +++ b/shell/platform/tizen/flutter_tizen_engine.cc @@ -343,7 +343,7 @@ void FlutterTizenEngine::SendPointerEvent(const FlutterPointerEvent& event) { void FlutterTizenEngine::SendWindowMetrics(int32_t width, int32_t height, double pixel_ratio) { - FlutterWindowMetricsEvent event; + FlutterWindowMetricsEvent event = {}; event.struct_size = sizeof(FlutterWindowMetricsEvent); event.width = width; event.height = height; diff --git a/shell/platform/tizen/touch_event_handler.cc b/shell/platform/tizen/touch_event_handler.cc index 69b7b1363f5da..70b8276e93a20 100644 --- a/shell/platform/tizen/touch_event_handler.cc +++ b/shell/platform/tizen/touch_event_handler.cc @@ -67,6 +67,7 @@ void TouchEventHandler::SendFlutterPointerEvent(FlutterPointerPhase phase, event.scroll_delta_y = scroll_delta_y * 2; event.timestamp = timestamp * 1000; event.device = device_id; + event.device_kind = kFlutterPointerDeviceKindTouch; engine_->SendPointerEvent(event); } From 85c9563ae4b06402f5a016fe21b4fe46bbc6f3bb Mon Sep 17 00:00:00 2001 From: Swift Kim Date: Mon, 27 Sep 2021 21:28:47 +0900 Subject: [PATCH 3/3] Remove the format job --- azure-pipelines.yml | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index 503859e4aabbe..fe86bc2865283 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -8,17 +8,7 @@ pr: - flutter-*-tizen jobs: -- job: format - pool: - name: Default - demands: Agent.os -equals Linux - steps: - - checkout: self - path: src/flutter - - bash: ci/format.sh - displayName: Verify formatting - job: test - dependsOn: format pool: name: Default demands: agent.os -equals Linux