From 352a3a6aa57c11c9b0c0c91c0f31765f0a48b1c7 Mon Sep 17 00:00:00 2001 From: Swift Kim Date: Mon, 14 Mar 2022 15:33:59 +0900 Subject: [PATCH 1/2] [ci] Fix artifact upload failure and hash mismatch --- .github/workflows/build.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 8af6bbaeb8806..550166ddb94d3 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -84,6 +84,10 @@ jobs: --build-tizen-shell ninja -C src/out/$OUTPUT_NAME tizen + if [ "${{ matrix.mode }}" != "debug" ]; then + ninja -C src/out/$OUTPUT_NAME clang_x64/gen_snapshot + fi + # Build unittests. if [ "$OUTPUT_NAME" = "linux_release_arm" ]; then ninja -C src/out/$OUTPUT_NAME flutter_tizen_unittests @@ -294,7 +298,7 @@ jobs: with: name: ${{ env.VERSION }} (${{ env.TAG_NAME }}) tag_name: ${{ env.TAG_NAME }} - target_commitish: ${{ github.ref_name }} + target_commitish: ${{ github.sha }} files: tizen-*.zip body: | Flutter engine ${{ env.VERSION }} for Tizen From 58d30417ce1e0f9cd107e0f14b223bc6fb09f93b Mon Sep 17 00:00:00 2001 From: Swift Kim Date: Mon, 14 Mar 2022 17:34:25 +0900 Subject: [PATCH 2/2] Error if artifact is not found --- .github/workflows/build.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 550166ddb94d3..7d9038db8baa2 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -100,11 +100,13 @@ jobs: with: name: tizen-arm-unittests path: src/out/${{ env.OUTPUT_NAME }}/*_unittests + if-no-files-found: error - uses: actions/upload-artifact@v2 with: name: tizen-${{ matrix.arch }}-${{ matrix.mode }} path: src/out/${{ env.OUTPUT_NAME }}/libflutter_*.so + if-no-files-found: error - uses: actions/upload-artifact@v2 if: matrix.arch == 'arm' && matrix.mode == 'release' @@ -115,12 +117,14 @@ jobs: src/out/linux_release_arm/public src/out/linux_release_arm/cpp_client_wrapper !src/out/linux_release_arm/cpp_client_wrapper/engine_method_result.cc + if-no-files-found: error - uses: actions/upload-artifact@v2 if: (matrix.arch == 'arm' || matrix.arch == 'arm64') && matrix.mode != 'debug' with: name: tizen-${{ matrix.arch }}-${{ matrix.mode }}_linux-x64 path: src/out/${{ env.OUTPUT_NAME }}/clang_x64/gen_snapshot + if-no-files-found: error windows-build: runs-on: windows-2019 @@ -178,6 +182,7 @@ jobs: with: name: tizen-${{ matrix.arch }}-${{ matrix.mode }}_windows-x64 path: C:\workspace\engine\src\out\${{ env.OUTPUT_NAME }}\gen_snapshot.exe + if-no-files-found: error macos-build: runs-on: macos-11 @@ -241,6 +246,7 @@ jobs: with: name: tizen-${{ matrix.arch }}-${{ matrix.mode }}_darwin-x64 path: src/out/${{ env.OUTPUT_NAME }}/clang_x64/gen_snapshot + if-no-files-found: error test: needs: build