[various] Enable avoid_print (part 2)

swift-kim · swift-kim · commit e29f06384f62 · 2023-03-09T17:18:58.000+09:00
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -1,4 +1,5 @@
-# This file is a copy of analysis_options.yaml from flutter/packages repo.
+# This file is a copy of analysis_options.yaml from flutter/packages repo
+# as of 2022-12-15.
 
 analyzer:
   language:
diff --git a/packages/camera/example/integration_test/camera_test.dart b/packages/camera/example/integration_test/camera_test.dart
@@ -48,8 +48,6 @@ void main() {
   Future<bool> testCaptureImageResolution(
       CameraController controller, ResolutionPreset preset) async {
     final Size expectedSize = presetExpectedSizes[preset]!;
-    print(
-        'Capturing photo at $preset (${expectedSize.width}x${expectedSize.height}) using camera ${controller.description.name}');
 
     // Take Picture
     final XFile file = await controller.takePicture();
@@ -93,8 +91,6 @@ void main() {
   Future<bool> testCaptureVideoResolution(
       CameraController controller, ResolutionPreset preset) async {
     final Size expectedSize = presetExpectedSizes[preset]!;
-    print(
-        'Capturing video at $preset (${expectedSize.width}x${expectedSize.height}) using camera ${controller.description.name}');
 
     // Take Video
     await controller.startVideoRecording();
diff --git a/packages/camera/example/lib/main.dart b/packages/camera/example/lib/main.dart
@@ -37,11 +37,8 @@ IconData getCameraLensIcon(CameraLensDirection direction) {
 }
 
 void _logError(String code, String? message) {
-  if (message != null) {
-    print('Error: $code\nError Message: $message');
-  } else {
-    print('Error: $code');
-  }
+  // ignore: avoid_print
+  print('Error: $code${message == null ? '' : '\nError Message: $message'}');
 }
 
 class _CameraExampleHomeState extends State<CameraExampleHome>
diff --git a/packages/firebase_core/example/lib/main.dart b/packages/firebase_core/example/lib/main.dart
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// ignore_for_file: public_member_api_docs
+// ignore_for_file: public_member_api_docs, avoid_print
 
 import 'dart:async';
 import 'dart:developer';
diff --git a/packages/google_maps_flutter/example/lib/map_coordinates.dart b/packages/google_maps_flutter/example/lib/map_coordinates.dart
@@ -72,7 +72,7 @@ class _MapCoordinatesBodyState extends State<_MapCoordinatesBody> {
           // Add a block at the bottom of this list to allow validation that the visible region of the map
           // does not change when scrolled under the safe view on iOS.
           // https://github.com/flutter/flutter/issues/107913
-          Container(
+          const SizedBox(
             width: 300,
             height: 1000,
           ),
diff --git a/packages/google_maps_flutter/lib/src/convert.dart b/packages/google_maps_flutter/lib/src/convert.dart
@@ -171,7 +171,7 @@ LatLngBounds _convertToBounds(String value) {
           northeast: LatLng(bound['north'] as double, bound['east'] as double));
     }
   } catch (e) {
-    print('Javascript Error: $e');
+    debugPrint('Javascript Error: $e');
   }
   return util.nullLatLngBounds;
 }
@@ -184,7 +184,7 @@ LatLng _convertToLatLng(String value) {
       return LatLng((latlng['lat'] as num) + 0.0, (latlng['lng'] as num) + 0.0);
     }
   } catch (e) {
-    print('Javascript Error: $e');
+    debugPrint('Javascript Error: $e');
   }
   return util.nullLatLng;
 }
@@ -205,7 +205,7 @@ ScreenCoordinate _convertToPoint(String value) {
       return ScreenCoordinate(x: x, y: y);
     }
   } catch (e) {
-    print('Javascript Error: $e');
+    debugPrint('Javascript Error: $e');
   }
   return util.nullScreenCoordinate;
 }
diff --git a/packages/google_maps_flutter/lib/src/google_maps_controller.dart b/packages/google_maps_flutter/lib/src/google_maps_controller.dart
@@ -229,7 +229,7 @@ class GoogleMapsController {
             _streamController.add(MapReadyEvent(_mapId));
             _isFirst = true;
           } catch (e) {
-            print('Javascript Error: $e');
+            debugPrint('Javascript Error: $e');
           }
         });
   }
@@ -250,7 +250,7 @@ class GoogleMapsController {
               _streamController.add(MapTapEvent(_mapId, position));
             }
           } catch (e) {
-            print('Javascript Error: $e');
+            debugPrint('Javascript Error: $e');
           }
         });
   }
@@ -272,7 +272,7 @@ class GoogleMapsController {
               _streamController.add(MapLongPressEvent(_mapId, position));
             }
           } catch (e) {
-            print('Javascript Error: $e');
+            debugPrint('Javascript Error: $e');
           }
         });
   }
@@ -295,7 +295,7 @@ class GoogleMapsController {
               }
             }
           } catch (e) {
-            print('Javascript Error: $e');
+            debugPrint('Javascript Error: $e');
           }
         });
   }
@@ -327,7 +327,7 @@ class GoogleMapsController {
               }
             }
           } catch (e) {
-            print('Javascript Error: $e');
+            debugPrint('Javascript Error: $e');
           }
         });
   }
@@ -351,7 +351,7 @@ class GoogleMapsController {
               }
             }
           } catch (e) {
-            print('Javascript Error: $e');
+            debugPrint('Javascript Error: $e');
           }
         });
   }
@@ -375,7 +375,7 @@ class GoogleMapsController {
               }
             }
           } catch (e) {
-            print('Javascript Error: $e');
+            debugPrint('Javascript Error: $e');
           }
         });
   }
@@ -398,7 +398,7 @@ class GoogleMapsController {
               }
             }
           } catch (e) {
-            print('Javascript Error: $e');
+            debugPrint('Javascript Error: $e');
           }
         });
   }
@@ -542,7 +542,7 @@ class GoogleMapsController {
     try {
       return double.parse(await _callMethod(c, 'getZoom', <String>[]));
     } catch (e) {
-      print('Javascript Error: $e');
+      debugPrint('Javascript Error: $e');
       return 0.0;
     }
   }
@@ -614,7 +614,7 @@ class GoogleMapsController {
             focusLatLng = await _pixelToLatLng(
                 json[2][0] as double, json[2][1] as double);
           } catch (e) {
-            print('Error computing focus LatLng. JS Error: $e');
+            debugPrint('Error computing focus LatLng. JS Error: $e');
           }
         }
         await _setZoom('${(await getZoomLevel()) + newZoomDelta}');
diff --git a/packages/google_sign_in/example/lib/main.dart b/packages/google_sign_in/example/lib/main.dart
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// ignore_for_file: public_member_api_docs
+// ignore_for_file: public_member_api_docs, avoid_print
 
 import 'dart:async';
 import 'dart:convert' show json;
diff --git a/packages/image_picker/example/lib/main.dart b/packages/image_picker/example/lib/main.dart
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// ignore_for_file: public_member_api_docs
+// ignore_for_file: public_member_api_docs, avoid_print
 
 import 'dart:async';
 import 'dart:io';
diff --git a/packages/messageport/example/integration_test/messageport_test.dart b/packages/messageport/example/integration_test/messageport_test.dart
@@ -76,9 +76,7 @@ void main() {
     final LocalPort localPort = await LocalPort.create(kTestPort);
     final Completer<List<dynamic>> completer = Completer<List<dynamic>>();
     localPort.register((dynamic message, [RemotePort? remotePort]) {
-      if (completer.isCompleted) {
-        print('WARNING: additional message received: $message');
-      } else {
+      if (!completer.isCompleted) {
         completer.complete(<dynamic>[message, remotePort]);
       }
     });
diff --git a/packages/shared_preferences/lib/shared_preferences_tizen.dart b/packages/shared_preferences/lib/shared_preferences_tizen.dart
@@ -120,8 +120,7 @@ class SharedPreferencesPlugin extends SharedPreferencesStorePlatform {
                 .toNativeChar(allocator: arena),
           );
         default:
-          print('Not implemented: valueType[$valueType]');
-          return -1;
+          throw UnimplementedError('Not supported type: $valueType');
       }
     });
     if (ret == 0) {
diff --git a/packages/tizen_rpc_port/example/client/lib/message_client.dart b/packages/tizen_rpc_port/example/client/lib/message_client.dart
@@ -102,9 +102,8 @@ class Message extends ProxyBase {
     final Parcel parcel = Parcel.fromPort(port);
     final int cmd = parcel.readInt32();
     if (cmd != _MethodId.result.id) {
-      print('Received parcel is invalid. $cmd');
+      throw Exception('The received parcel is invalid ($cmd).');
     }
-
     return parcel;
   }
 
diff --git a/packages/tizen_rpc_port/example/server/lib/main.dart b/packages/tizen_rpc_port/example/server/lib/main.dart
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// ignore_for_file: public_member_api_docs
+// ignore_for_file: public_member_api_docs, avoid_print
 
 import 'dart:async';
 
diff --git a/packages/tizen_rpc_port/lib/src/proxy_base.dart b/packages/tizen_rpc_port/lib/src/proxy_base.dart
@@ -6,6 +6,7 @@ import 'dart:async';
 import 'dart:ffi';
 
 import 'package:ffi/ffi.dart';
+import 'package:flutter/foundation.dart';
 import 'package:flutter/services.dart';
 import 'package:tizen_interop/6.5/tizen.dart';
 
@@ -122,7 +123,7 @@ abstract class ProxyBase {
         final Parcel parcel = Parcel.fromRaw(rawData);
         await onReceivedEvent(parcel);
       } else {
-        print('Unknown event: $event');
+        debugPrint('Unknown event: $event');
       }
     }, onError: onError);
 
diff --git a/packages/tizen_rpc_port/lib/src/stub_base.dart b/packages/tizen_rpc_port/lib/src/stub_base.dart
@@ -6,6 +6,7 @@ import 'dart:async';
 import 'dart:ffi';
 
 import 'package:ffi/ffi.dart';
+import 'package:flutter/foundation.dart';
 import 'package:flutter/services.dart';
 import 'package:tizen_interop/6.5/tizen.dart';
 
@@ -101,7 +102,7 @@ abstract class StubBase {
         final Parcel parcel = Parcel.fromRaw(rawData);
         await onReceivedEvent(sender, instance, parcel);
       } else {
-        print('Unknown event: $event');
+        debugPrint('Unknown event: $event');
       }
     }, onError: onError);
   }
diff --git a/packages/url_launcher/example/lib/main.dart b/packages/url_launcher/example/lib/main.dart
@@ -196,7 +196,6 @@ class _MyHomePageState extends State<MyHomePage> {
                 onPressed: () => setState(() {
                   _launched = _launchInWebViewOrVC(toLaunch);
                   Timer(const Duration(seconds: 5), () {
-                    print('Closing WebView after 5 seconds...');
                     closeInAppWebView();
                   });
                 }),
diff --git a/packages/webview_flutter/example/lib/main.dart b/packages/webview_flutter/example/lib/main.dart
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// ignore_for_file: public_member_api_docs
+// ignore_for_file: public_member_api_docs, avoid_print
 
 import 'dart:async';
 import 'dart:convert';
diff --git a/packages/webview_flutter_lwe/example/lib/main.dart b/packages/webview_flutter_lwe/example/lib/main.dart
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// ignore_for_file: public_member_api_docs
+// ignore_for_file: public_member_api_docs, avoid_print
 
 import 'dart:async';
 import 'dart:convert';

Original file line number	Diff line number	Diff line change
`@@ -37,11 +37,8 @@ IconData getCameraLensIcon(CameraLensDirection direction) {`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`void _logError(String code, String? message) {`
`40`		`- if (message != null) {`
`41`		`- print('Error: $code\nError Message: $message');`
`42`		`- } else {`
`43`		`- print('Error: $code');`
`44`		`- }`
	`40`	`+ // ignore: avoid_print`
	`41`	`+ print('Error: $code${message == null ? '' : '\nError Message: $message'}');`
`45`	`42`	`}`
`46`	`43`
`47`	`44`	`class _CameraExampleHomeState extends State<CameraExampleHome>`
Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ LatLngBounds _convertToBounds(String value) {`
`171`	`171`	`northeast: LatLng(bound['north'] as double, bound['east'] as double));`
`172`	`172`	`}`
`173`	`173`	`} catch (e) {`
`174`		`- print('Javascript Error: $e');`
	`174`	`+ debugPrint('Javascript Error: $e');`
`175`	`175`	`}`
`176`	`176`	`return util.nullLatLngBounds;`
`177`	`177`	`}`
`@@ -184,7 +184,7 @@ LatLng _convertToLatLng(String value) {`
`184`	`184`	`return LatLng((latlng['lat'] as num) + 0.0, (latlng['lng'] as num) + 0.0);`
`185`	`185`	`}`
`186`	`186`	`} catch (e) {`
`187`		`- print('Javascript Error: $e');`
	`187`	`+ debugPrint('Javascript Error: $e');`
`188`	`188`	`}`
`189`	`189`	`return util.nullLatLng;`
`190`	`190`	`}`
`@@ -205,7 +205,7 @@ ScreenCoordinate _convertToPoint(String value) {`
`205`	`205`	`return ScreenCoordinate(x: x, y: y);`
`206`	`206`	`}`
`207`	`207`	`} catch (e) {`
`208`		`- print('Javascript Error: $e');`
	`208`	`+ debugPrint('Javascript Error: $e');`
`209`	`209`	`}`
`210`	`210`	`return util.nullScreenCoordinate;`
`211`	`211`	`}`
Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ class GoogleMapsController {`
`229`	`229`	`_streamController.add(MapReadyEvent(_mapId));`
`230`	`230`	`_isFirst = true;`
`231`	`231`	`} catch (e) {`
`232`		`- print('Javascript Error: $e');`
	`232`	`+ debugPrint('Javascript Error: $e');`
`233`	`233`	`}`
`234`	`234`	`});`
`235`	`235`	`}`
`@@ -250,7 +250,7 @@ class GoogleMapsController {`
`250`	`250`	`_streamController.add(MapTapEvent(_mapId, position));`
`251`	`251`	`}`
`252`	`252`	`} catch (e) {`
`253`		`- print('Javascript Error: $e');`
	`253`	`+ debugPrint('Javascript Error: $e');`
`254`	`254`	`}`
`255`	`255`	`});`
`256`	`256`	`}`
`@@ -272,7 +272,7 @@ class GoogleMapsController {`
`272`	`272`	`_streamController.add(MapLongPressEvent(_mapId, position));`
`273`	`273`	`}`
`274`	`274`	`} catch (e) {`
`275`		`- print('Javascript Error: $e');`
	`275`	`+ debugPrint('Javascript Error: $e');`
`276`	`276`	`}`
`277`	`277`	`});`
`278`	`278`	`}`
`@@ -295,7 +295,7 @@ class GoogleMapsController {`
`295`	`295`	`}`
`296`	`296`	`}`
`297`	`297`	`} catch (e) {`
`298`		`- print('Javascript Error: $e');`
	`298`	`+ debugPrint('Javascript Error: $e');`
`299`	`299`	`}`
`300`	`300`	`});`
`301`	`301`	`}`
`@@ -327,7 +327,7 @@ class GoogleMapsController {`
`327`	`327`	`}`
`328`	`328`	`}`
`329`	`329`	`} catch (e) {`
`330`		`- print('Javascript Error: $e');`
	`330`	`+ debugPrint('Javascript Error: $e');`
`331`	`331`	`}`
`332`	`332`	`});`
`333`	`333`	`}`
`@@ -351,7 +351,7 @@ class GoogleMapsController {`
`351`	`351`	`}`
`352`	`352`	`}`
`353`	`353`	`} catch (e) {`
`354`		`- print('Javascript Error: $e');`
	`354`	`+ debugPrint('Javascript Error: $e');`
`355`	`355`	`}`
`356`	`356`	`});`
`357`	`357`	`}`
`@@ -375,7 +375,7 @@ class GoogleMapsController {`
`375`	`375`	`}`
`376`	`376`	`}`
`377`	`377`	`} catch (e) {`
`378`		`- print('Javascript Error: $e');`
	`378`	`+ debugPrint('Javascript Error: $e');`
`379`	`379`	`}`
`380`	`380`	`});`
`381`	`381`	`}`
`@@ -398,7 +398,7 @@ class GoogleMapsController {`
`398`	`398`	`}`
`399`	`399`	`}`
`400`	`400`	`} catch (e) {`
`401`		`- print('Javascript Error: $e');`
	`401`	`+ debugPrint('Javascript Error: $e');`
`402`	`402`	`}`
`403`	`403`	`});`
`404`	`404`	`}`
`@@ -542,7 +542,7 @@ class GoogleMapsController {`
`542`	`542`	`try {`
`543`	`543`	`return double.parse(await _callMethod(c, 'getZoom', <String>[]));`
`544`	`544`	`} catch (e) {`
`545`		`- print('Javascript Error: $e');`
	`545`	`+ debugPrint('Javascript Error: $e');`
`546`	`546`	`return 0.0;`
`547`	`547`	`}`
`548`	`548`	`}`
`@@ -614,7 +614,7 @@ class GoogleMapsController {`
`614`	`614`	`focusLatLng = await _pixelToLatLng(`
`615`	`615`	`json[2][0] as double, json[2][1] as double);`
`616`	`616`	`} catch (e) {`
`617`		`- print('Error computing focus LatLng. JS Error: $e');`
	`617`	`+ debugPrint('Error computing focus LatLng. JS Error: $e');`
`618`	`618`	`}`
`619`	`619`	`}`
`620`	`620`	`await _setZoom('${(await getZoomLevel()) + newZoomDelta}');`