From e400a326bac09ccfae0adf30f8019976e8822180 Mon Sep 17 00:00:00 2001 From: Jaime Wren Date: Mon, 28 Jul 2025 13:11:02 -0700 Subject: [PATCH 1/2] Modify the presubmit.yaml to include MacOS and Windows as included systems to validate tests and the verifier against --- .github/workflows/presubmit.yaml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index 48b54c7ff..6ce2fb7fd 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -31,7 +31,10 @@ jobs: # Job 2: Unit Tests unit-tests: - runs-on: ubuntu-latest + strategy: + matrix: + os: [ ubuntu-latest, macos-latest, windows-latest ] + runs-on: ${{ matrix.os }} # Use the OS from the matrix steps: - name: Checkout code uses: actions/checkout@v4 # Use the latest stable version of actions/checkout @@ -49,7 +52,10 @@ jobs: # Job 3: Verify Plugin verify-plugin: - runs-on: ubuntu-latest + strategy: + matrix: + os: [ ubuntu-latest, macos-latest, windows-latest ] + runs-on: ${{ matrix.os }} # Use the OS from the matrix steps: - name: Checkout code uses: actions/checkout@v4 # Use the latest stable version of actions/checkout From f474ea9ffdf65ea4201b35d42bf74d4ed4da4545 Mon Sep 17 00:00:00 2001 From: Jaime Wren Date: Mon, 28 Jul 2025 13:31:58 -0700 Subject: [PATCH 2/2] Changing to remove windows from running the presubmits, I'll create an issue to fix the tests on windows. --- .github/workflows/presubmit.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index 6ce2fb7fd..71c1b7670 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -33,7 +33,7 @@ jobs: unit-tests: strategy: matrix: - os: [ ubuntu-latest, macos-latest, windows-latest ] + os: [ ubuntu-latest, macos-latest ] runs-on: ${{ matrix.os }} # Use the OS from the matrix steps: - name: Checkout code