From 3711e2e2e1da4dca0ecde36e9f9060204da7b589 Mon Sep 17 00:00:00 2001 From: Phil Quitslund Date: Thu, 20 Nov 2025 17:35:21 -0800 Subject: [PATCH 01/13] [tests] upload test report artifacts --- .github/workflows/presubmit.yaml | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index 1a5e501fa..4a9bd9974 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -119,3 +119,27 @@ jobs: ./gradlew verifyPluginSignature ./gradlew verifyPluginStructure working-directory: third_party + # Job 5: Upload Test Report + upload-report: + needs: dart-analysis-server-tests + strategy: + matrix: + # https://github.com/dart-lang/setup-dart + # Define the Dart SDK versions to test against. + # 'stable' and 'beta' will fetch the latest respective versions. + # You can also specify exact versions like '3.0.0', '3.8.1'. + # dart-version: ['3.0.0', 'stable', 'beta', 'dev' ] + + # TODO(https://github.com/flutter/dart-intellij-third-party/issues/47) + # Fix tests to run over additional operating systems as well as Dart SDK versions: + dart-version: ['stable'] + os: [ macos-latest ] + runs-on: ${{ matrix.os }} # Use the OS from the matrix + steps: + - name: Upload Test Report Artifact + uses: actions/upload-artifact@v4 + if: always() # IMPORTANT: Upload reports even if the tests fail + with: + name: gradle-test-report-${{ matrix.dart-version }}-${{ matrix.os }} + path: third_party/build/reports/tests/test + retention-days: 7 From 9acdf06893c63aedbc76fe0c08035927f0b35a75 Mon Sep 17 00:00:00 2001 From: Phil Quitslund Date: Thu, 20 Nov 2025 17:46:15 -0800 Subject: [PATCH 02/13] try full path --- .github/workflows/presubmit.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index 4a9bd9974..68d69a6dd 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -141,5 +141,5 @@ jobs: if: always() # IMPORTANT: Upload reports even if the tests fail with: name: gradle-test-report-${{ matrix.dart-version }}-${{ matrix.os }} - path: third_party/build/reports/tests/test + path: third_party/build/reports/tests/test/index.html retention-days: 7 From 55a141e936fda2a8a12279b53c180ce885a5968f Mon Sep 17 00:00:00 2001 From: Phil Quitslund Date: Thu, 20 Nov 2025 18:06:49 -0800 Subject: [PATCH 03/13] add problem report --- .github/workflows/presubmit.yaml | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index 68d69a6dd..15fcbf9f4 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -143,3 +143,27 @@ jobs: name: gradle-test-report-${{ matrix.dart-version }}-${{ matrix.os }} path: third_party/build/reports/tests/test/index.html retention-days: 7 + # Job 6: Upload Test Report + upload-problems: + needs: dart-analysis-server-tests + strategy: + matrix: + # https://github.com/dart-lang/setup-dart + # Define the Dart SDK versions to test against. + # 'stable' and 'beta' will fetch the latest respective versions. + # You can also specify exact versions like '3.0.0', '3.8.1'. + # dart-version: ['3.0.0', 'stable', 'beta', 'dev' ] + + # TODO(https://github.com/flutter/dart-intellij-third-party/issues/47) + # Fix tests to run over additional operating systems as well as Dart SDK versions: + dart-version: ['stable'] + os: [ macos-latest ] + runs-on: ${{ matrix.os }} # Use the OS from the matrix + steps: + - name: Upload Problem Report Artifact + uses: actions/upload-artifact@v4 + if: always() # IMPORTANT: Upload reports even if the tests fail + with: + name: gradle-problem-report-${{ matrix.dart-version }}-${{ matrix.os }} + path: third_party/build/reports/problems/problems-report.html + retention-days: 7 From cda38f98eace39da49bf0ef7ac506d38d3ba28d5 Mon Sep 17 00:00:00 2001 From: Phil Quitslund Date: Thu, 20 Nov 2025 18:20:51 -0800 Subject: [PATCH 04/13] path goofery --- .github/workflows/presubmit.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index 15fcbf9f4..0681ebb4f 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -120,7 +120,7 @@ jobs: ./gradlew verifyPluginStructure working-directory: third_party # Job 5: Upload Test Report - upload-report: + upload-test-report: needs: dart-analysis-server-tests strategy: matrix: @@ -141,7 +141,7 @@ jobs: if: always() # IMPORTANT: Upload reports even if the tests fail with: name: gradle-test-report-${{ matrix.dart-version }}-${{ matrix.os }} - path: third_party/build/reports/tests/test/index.html + path: Users/runner/work/dart-intellij-third-party/dart-intellij-third-party/third_party/build/reports/tests/test/index.html retention-days: 7 # Job 6: Upload Test Report upload-problems: @@ -165,5 +165,5 @@ jobs: if: always() # IMPORTANT: Upload reports even if the tests fail with: name: gradle-problem-report-${{ matrix.dart-version }}-${{ matrix.os }} - path: third_party/build/reports/problems/problems-report.html + path: ///Users/runner/work/dart-intellij-third-party/dart-intellij-third-party/third_party/build/reports/problems/problems-report.html retention-days: 7 From 7b9760ec4255ab6f46b212cc3503bc5c3102279f Mon Sep 17 00:00:00 2001 From: Phil Quitslund Date: Thu, 20 Nov 2025 18:32:15 -0800 Subject: [PATCH 05/13] try inlining upload --- .github/workflows/presubmit.yaml | 56 ++++---------------------------- 1 file changed, 7 insertions(+), 49 deletions(-) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index 0681ebb4f..d07f028d3 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -93,7 +93,13 @@ jobs: run: | ./gradlew :test --tests "com.jetbrains.dart.analysisServer.*" working-directory: third_party - + - name: Upload build reports + uses: actions/upload-artifact@v4 + with: + name: build + path: | + **/build/reports/ + **/build/test-results/ # Job 4: Verify Plugin verify-plugin: needs: build-plugin @@ -119,51 +125,3 @@ jobs: ./gradlew verifyPluginSignature ./gradlew verifyPluginStructure working-directory: third_party - # Job 5: Upload Test Report - upload-test-report: - needs: dart-analysis-server-tests - strategy: - matrix: - # https://github.com/dart-lang/setup-dart - # Define the Dart SDK versions to test against. - # 'stable' and 'beta' will fetch the latest respective versions. - # You can also specify exact versions like '3.0.0', '3.8.1'. - # dart-version: ['3.0.0', 'stable', 'beta', 'dev' ] - - # TODO(https://github.com/flutter/dart-intellij-third-party/issues/47) - # Fix tests to run over additional operating systems as well as Dart SDK versions: - dart-version: ['stable'] - os: [ macos-latest ] - runs-on: ${{ matrix.os }} # Use the OS from the matrix - steps: - - name: Upload Test Report Artifact - uses: actions/upload-artifact@v4 - if: always() # IMPORTANT: Upload reports even if the tests fail - with: - name: gradle-test-report-${{ matrix.dart-version }}-${{ matrix.os }} - path: Users/runner/work/dart-intellij-third-party/dart-intellij-third-party/third_party/build/reports/tests/test/index.html - retention-days: 7 - # Job 6: Upload Test Report - upload-problems: - needs: dart-analysis-server-tests - strategy: - matrix: - # https://github.com/dart-lang/setup-dart - # Define the Dart SDK versions to test against. - # 'stable' and 'beta' will fetch the latest respective versions. - # You can also specify exact versions like '3.0.0', '3.8.1'. - # dart-version: ['3.0.0', 'stable', 'beta', 'dev' ] - - # TODO(https://github.com/flutter/dart-intellij-third-party/issues/47) - # Fix tests to run over additional operating systems as well as Dart SDK versions: - dart-version: ['stable'] - os: [ macos-latest ] - runs-on: ${{ matrix.os }} # Use the OS from the matrix - steps: - - name: Upload Problem Report Artifact - uses: actions/upload-artifact@v4 - if: always() # IMPORTANT: Upload reports even if the tests fail - with: - name: gradle-problem-report-${{ matrix.dart-version }}-${{ matrix.os }} - path: ///Users/runner/work/dart-intellij-third-party/dart-intellij-third-party/third_party/build/reports/problems/problems-report.html - retention-days: 7 From c3a0318c794795ae9cbe5e3f5b7f2f544f774857 Mon Sep 17 00:00:00 2001 From: Phil Quitslund Date: Thu, 20 Nov 2025 18:46:00 -0800 Subject: [PATCH 06/13] +++ --- .github/workflows/presubmit.yaml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index d07f028d3..be288afb9 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -125,3 +125,26 @@ jobs: ./gradlew verifyPluginSignature ./gradlew verifyPluginStructure working-directory: third_party + # Job 5: Upload Build artifacts + upload-artifacts: + needs: dart-analysis-server-tests + strategy: + matrix: + # https://github.com/dart-lang/setup-dart + # Define the Dart SDK versions to test against. + # 'stable' and 'beta' will fetch the latest respective versions. + # You can also specify exact versions like '3.0.0', '3.8.1'. + # dart-version: ['3.0.0', 'stable', 'beta', 'dev' ] + # TODO(https://github.com/flutter/dart-intellij-third-party/issues/47) + # Fix tests to run over additional operating systems as well as Dart SDK versions: + dart-version: ['stable'] + os: [ macos-latest ] + runs-on: ${{ matrix.os }} # Use the OS from the matrix + steps: + - name: Upload build artifacts + uses: actions/upload-artifact@v4 + with: + name: build + path: | + **/build/reports/ + **/build/test-results/ From 27e2cf075ae537ce7c9e0b3ce3069e18eb6aa8ae Mon Sep 17 00:00:00 2001 From: Phil Quitslund Date: Thu, 20 Nov 2025 18:46:33 -0800 Subject: [PATCH 07/13] --- --- .github/workflows/presubmit.yaml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index be288afb9..e877efbf0 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -93,13 +93,6 @@ jobs: run: | ./gradlew :test --tests "com.jetbrains.dart.analysisServer.*" working-directory: third_party - - name: Upload build reports - uses: actions/upload-artifact@v4 - with: - name: build - path: | - **/build/reports/ - **/build/test-results/ # Job 4: Verify Plugin verify-plugin: needs: build-plugin From 384dfb0060eb01725543f8207a201af92d6c0aad Mon Sep 17 00:00:00 2001 From: Phil Quitslund Date: Thu, 20 Nov 2025 19:23:26 -0800 Subject: [PATCH 08/13] ${{ github.workspace }} --- .github/workflows/presubmit.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index e877efbf0..f73bc8746 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -139,5 +139,5 @@ jobs: with: name: build path: | - **/build/reports/ - **/build/test-results/ + ${{ github.workspace }}/build/reports/ + ${{ github.workspace }}/build/test-results/ From 81a81d5f05f0f473a088b87370f56668cb4e733a Mon Sep 17 00:00:00 2001 From: Phil Quitslund Date: Thu, 20 Nov 2025 19:32:44 -0800 Subject: [PATCH 09/13] /// --- .github/workflows/presubmit.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index f73bc8746..36a5d9884 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -136,6 +136,7 @@ jobs: steps: - name: Upload build artifacts uses: actions/upload-artifact@v4 + if: always() with: name: build path: | From 7b7cc5a4c0044f8181e023bb6b6c44d4edef4989 Mon Sep 17 00:00:00 2001 From: Phil Quitslund Date: Thu, 20 Nov 2025 19:48:44 -0800 Subject: [PATCH 10/13] pluginVerifier --- .github/workflows/presubmit.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index 36a5d9884..4ea0a91ed 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -118,6 +118,13 @@ jobs: ./gradlew verifyPluginSignature ./gradlew verifyPluginStructure working-directory: third_party + # Collect Plugin Verifier Results + - name: Collect Plugin Verifier Results + if: ${{ always() }} + uses: actions/upload-artifact@v4 + with: + name: pluginVerifier-results + path: ${{ github.workspace }}/build/reports/pluginVerifier # Job 5: Upload Build artifacts upload-artifacts: needs: dart-analysis-server-tests From d7a3ddb49e625128be3a5ddfd3b622ad006a8fab Mon Sep 17 00:00:00 2001 From: Phil Quitslund Date: Thu, 20 Nov 2025 19:50:01 -0800 Subject: [PATCH 11/13] inline (again) --- .github/workflows/presubmit.yaml | 32 ++++++++------------------------ 1 file changed, 8 insertions(+), 24 deletions(-) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index 4ea0a91ed..3ab341816 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -93,6 +93,14 @@ jobs: run: | ./gradlew :test --tests "com.jetbrains.dart.analysisServer.*" working-directory: third_party + - name: Upload build artifacts + uses: actions/upload-artifact@v4 + if: always() + with: + name: build + path: | + ${{ github.workspace }}/build/reports/ + ${{ github.workspace }}/build/test-results/ # Job 4: Verify Plugin verify-plugin: needs: build-plugin @@ -125,27 +133,3 @@ jobs: with: name: pluginVerifier-results path: ${{ github.workspace }}/build/reports/pluginVerifier - # Job 5: Upload Build artifacts - upload-artifacts: - needs: dart-analysis-server-tests - strategy: - matrix: - # https://github.com/dart-lang/setup-dart - # Define the Dart SDK versions to test against. - # 'stable' and 'beta' will fetch the latest respective versions. - # You can also specify exact versions like '3.0.0', '3.8.1'. - # dart-version: ['3.0.0', 'stable', 'beta', 'dev' ] - # TODO(https://github.com/flutter/dart-intellij-third-party/issues/47) - # Fix tests to run over additional operating systems as well as Dart SDK versions: - dart-version: ['stable'] - os: [ macos-latest ] - runs-on: ${{ matrix.os }} # Use the OS from the matrix - steps: - - name: Upload build artifacts - uses: actions/upload-artifact@v4 - if: always() - with: - name: build - path: | - ${{ github.workspace }}/build/reports/ - ${{ github.workspace }}/build/test-results/ From 0e4225250af4eaceaacdf133be684a879bbbd0fa Mon Sep 17 00:00:00 2001 From: Phil Quitslund Date: Thu, 20 Nov 2025 20:03:48 -0800 Subject: [PATCH 12/13] moar pathery --- .github/workflows/presubmit.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index 3ab341816..91e5a1c5c 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -99,8 +99,8 @@ jobs: with: name: build path: | - ${{ github.workspace }}/build/reports/ - ${{ github.workspace }}/build/test-results/ + **/build/reports/ + **/build/test-results/ # Job 4: Verify Plugin verify-plugin: needs: build-plugin @@ -132,4 +132,4 @@ jobs: uses: actions/upload-artifact@v4 with: name: pluginVerifier-results - path: ${{ github.workspace }}/build/reports/pluginVerifier + path: build/reports/pluginVerifier From 19a83ec26146bbd8fa20075e4c1a52537402c9af Mon Sep 17 00:00:00 2001 From: Phil Quitslund Date: Thu, 20 Nov 2025 20:25:05 -0800 Subject: [PATCH 13/13] -- --- .github/workflows/presubmit.yaml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index 91e5a1c5c..26e853147 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -126,10 +126,3 @@ jobs: ./gradlew verifyPluginSignature ./gradlew verifyPluginStructure working-directory: third_party - # Collect Plugin Verifier Results - - name: Collect Plugin Verifier Results - if: ${{ always() }} - uses: actions/upload-artifact@v4 - with: - name: pluginVerifier-results - path: build/reports/pluginVerifier