Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External links don't work when embedded in VSCode #3251

Closed
tomgilder opened this issue Aug 5, 2021 · 0 comments · Fixed by #3252
Closed

External links don't work when embedded in VSCode #3251

tomgilder opened this issue Aug 5, 2021 · 0 comments · Fixed by #3252

Comments

@tomgilder
Copy link
Contributor

External links don't launch when DevTools are embedded within VSCode.

This affects a several places, including the warning banners on the performance and memory views, and the new debug toggle tooltips.

The links fail silently - this is because the embedded VSCode Chrome view has the "allow-popups" sandbox flag disabled. Links work correctly in Android Studio.

I have a fix for this that also requires support in DartCode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix links opening when embedded in VSCode CodemateLtd/devtools
1 participant
@tomgilder