Add a logging screen test#1348
Merged
Merged
Conversation
Comment on lines
+60
to
+62
| testWidgets('can toggle structured errors', (WidgetTester tester) async { | ||
| await tester.pumpWidget(wrap(Builder(builder: screen.build))); | ||
| }); |
Member
There was a problem hiding this comment.
add logic to toggle structured errors on/off
Contributor
Author
There was a problem hiding this comment.
Good catch; done.
| expect(find.byKey(ValueKey(fakeLogData.first)), findsNothing, | ||
| reason: | ||
| 'the least recently added logdata should be at the top of the ' | ||
| 'list, hidden from view.'); |
Member
There was a problem hiding this comment.
nit: trailing comma - here and in expect statement above
kenzieschmoll
approved these changes
Nov 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, give more control to Table clients over how they create keys. We don't need the PageStorageKey in most cases.