From eabef026087fb693a6e9c205072f0c9385ec5267 Mon Sep 17 00:00:00 2001
From: Dan Chevalier <chevalier.dan@gmail.com>
Date: Fri, 3 Jun 2022 11:11:40 -0400
Subject: [PATCH] fix method allignment and remove manual truncation of methods

---
 .../src/screens/profiler/cpu_profile_columns.dart   |  6 ------
 .../lib/src/service/resolved_uri_manager.dart       |  1 +
 packages/devtools_app/lib/src/shared/table.dart     | 13 +++++++++++++
 3 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/packages/devtools_app/lib/src/screens/profiler/cpu_profile_columns.dart b/packages/devtools_app/lib/src/screens/profiler/cpu_profile_columns.dart
index 962995b14aa..3443e8e499d 100644
--- a/packages/devtools_app/lib/src/screens/profiler/cpu_profile_columns.dart
+++ b/packages/devtools_app/lib/src/screens/profiler/cpu_profile_columns.dart
@@ -79,17 +79,11 @@ class TotalTimeColumn extends ColumnData<CpuStackFrame> {
 
 class MethodNameColumn extends TreeColumnData<CpuStackFrame> {
   MethodNameColumn() : super('Method');
-
-  static const maxMethodNameLength = 75;
-
   @override
   dynamic getValue(CpuStackFrame dataObject) => dataObject.name;
 
   @override
   String getDisplayValue(CpuStackFrame dataObject) {
-    if (dataObject.name.length > maxMethodNameLength) {
-      return dataObject.name.substring(0, maxMethodNameLength) + '...';
-    }
     return dataObject.name;
   }
 
diff --git a/packages/devtools_app/lib/src/service/resolved_uri_manager.dart b/packages/devtools_app/lib/src/service/resolved_uri_manager.dart
index e53e40d680c..c902fb0dbd9 100644
--- a/packages/devtools_app/lib/src/service/resolved_uri_manager.dart
+++ b/packages/devtools_app/lib/src/service/resolved_uri_manager.dart
@@ -25,6 +25,7 @@ class ResolvedUriManager {
   /// [isolateId] The id of the isolate that the [uris] were generated on.
   /// [uris] List of uris to fetch package uris for.
   Future<void> fetchPackageUris(String isolateId, List<String> uris) async {
+    if (uris.isEmpty) return;
     if (_packagePathMappings != null) {
       final packageUris =
           (await serviceManager.service!.lookupPackageUris(isolateId, uris))
diff --git a/packages/devtools_app/lib/src/shared/table.dart b/packages/devtools_app/lib/src/shared/table.dart
index 1405cd22782..8f0fcf6784d 100644
--- a/packages/devtools_app/lib/src/shared/table.dart
+++ b/packages/devtools_app/lib/src/shared/table.dart
@@ -1302,6 +1302,18 @@ class _TableRowState<T> extends State<TableRow<T>>
     }
   }
 
+  TextAlign _textAlignmentFor(ColumnData<T> column) {
+    switch (column.alignment) {
+      case ColumnAlignment.center:
+        return TextAlign.center;
+      case ColumnAlignment.right:
+        return TextAlign.right;
+      case ColumnAlignment.left:
+      default:
+        return TextAlign.left;
+    }
+  }
+
   MainAxisAlignment _mainAxisAlignmentFor(ColumnData<T> column) {
     switch (column.alignment) {
       case ColumnAlignment.center:
@@ -1379,6 +1391,7 @@ class _TableRowState<T> extends State<TableRow<T>>
             overflow: TextOverflow.ellipsis,
             style: contentTextStyle(column),
             maxLines: 1,
+            textAlign: _textAlignmentFor(column),
           );
         }