From fc255e27ff4d393fe3c2e4fcd2b5ba24c21163e4 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Wed, 5 Apr 2023 11:23:57 -0700 Subject: [PATCH 1/3] Hide warning message --- .../devtools_app/lib/src/shared/console/eval/eval_service.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/devtools_app/lib/src/shared/console/eval/eval_service.dart b/packages/devtools_app/lib/src/shared/console/eval/eval_service.dart index 2811b7305da..81676f0d876 100644 --- a/packages/devtools_app/lib/src/shared/console/eval/eval_service.dart +++ b/packages/devtools_app/lib/src/shared/console/eval/eval_service.dart @@ -188,7 +188,7 @@ class EvalService extends DisposableController with AutoDisposeControllerMixin { bool isScopeSupported({bool emitWarningToConsole = false}) { // Web does not support scopes yet. final isWeb = serviceManager.connectedApp?.isDartWebAppNow ?? true; - if (isWeb) { + if (isWeb && emitWarningToConsole) { serviceManager.consoleService.appendStdio( 'Scope variables are not supported for web applications.', ); From 17361499b617557b37b2a1486675a3f784fe13f1 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Wed, 5 Apr 2023 11:53:47 -0700 Subject: [PATCH 2/3] Remove test_api pin now that https://github.com/dart-lang/test/issues/1977 has been resolved --- packages/devtools_app/pubspec.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/devtools_app/pubspec.yaml b/packages/devtools_app/pubspec.yaml index 1a98a4ed1b8..9467cab5ba2 100644 --- a/packages/devtools_app/pubspec.yaml +++ b/packages/devtools_app/pubspec.yaml @@ -75,9 +75,7 @@ dev_dependencies: sdk: flutter mockito: ^5.1.0 webkit_inspection_protocol: '>=0.5.0 <2.0.0' - stager: ^0.1.0 - # See https://github.com/dart-lang/test/issues/1977 - test_api: 0.4.18 + stager: ^1.0.0 flutter: uses-material-design: true From d10e5cea53ac6a9d6d1f7f07130db88f0889c914 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Wed, 5 Apr 2023 11:54:33 -0700 Subject: [PATCH 3/3] Committed in wrong directory --- packages/devtools_test/pubspec.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/devtools_test/pubspec.yaml b/packages/devtools_test/pubspec.yaml index 6dc75a70196..497fc069cdb 100644 --- a/packages/devtools_test/pubspec.yaml +++ b/packages/devtools_test/pubspec.yaml @@ -44,5 +44,4 @@ dev_dependencies: build_runner: ^2.3.3 integration_test: sdk: flutter - # See https://github.com/dart-lang/test/issues/1977 - test_api: 0.4.18 +