Skip to content

Hide warning message "Scope variables are not supported for web applications" #5612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 5, 2023
Merged

Hide warning message "Scope variables are not supported for web applications" #5612

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc255e2
Hide warning message
elliette Apr 5, 2023
1736149
Remove test_api pin now that https://github.com/dart-lang/test/issues…
elliette Apr 5, 2023
d10e5ce
Committed in wrong directory
elliette Apr 5, 2023
3e0df96
Resolve merge conflicts
elliette Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/devtools_app/lib/src/shared/console/eval/eval_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ class EvalService extends DisposableController with AutoDisposeControllerMixin {
bool isScopeSupported({bool emitWarningToConsole = false}) {
// Web does not support scopes yet.
final isWeb = serviceManager.connectedApp?.isDartWebAppNow ?? true;
if (isWeb) {
if (isWeb && emitWarningToConsole) {
serviceManager.consoleService.appendStdio(
'Scope variables are not supported for web applications.',
);
Expand Down