Migrate to new bootstrapping methods. #7599
Conversation
| function bootstrapAppFor1P() { | ||
| _flutter.loader.load({ | ||
| config: { | ||
| canvasKitBaseUrl: 'canvaskit/' |
There was a problem hiding this comment.
Looks like this is a change from the previous implementation, where we did not set the canvasKitBaseUrl field for 1P. @elliette do you remember why we needed separate bootstrapping for 1P? And does this look okay to you?
There was a problem hiding this comment.
Ah, that's just an oversight by me. I can remove that.
There was a problem hiding this comment.
I forget why the canvasKitBasUrl is only required for 3P, but in general the assets are located in slightly different locations for 1P vs 3P which is why there are two different implementations.
|
|
||
| // Bootstrap app for 1P environments: | ||
| function bootstrapAppFor1P() { | ||
| _flutter.loader.load(); |
There was a problem hiding this comment.
I'm guessing we also need to specify the entrypointUrl as main.dart.js, see #5705
There was a problem hiding this comment.
We should not need that, and the new API does not take an entryPointUrl as a parameter. The old API should have had that as the default and wouldn't have needed that anyway, so I'm not sure why that was needed before.
|
Note that we will need to update the DevTools copybara script as well, otherwise this will be break DevTools in google3. This is where we replace |
This reverts commit 694d552.
3 participants
This fixes #7444
flutter_bootstrap.jsfile.FlutterLoader.load()API fromFlutterLoader.loadEntrypoint()API.