From ae68faaa9dc13fb4ed46fa309d2030eb61ed3239 Mon Sep 17 00:00:00 2001 From: Sam Rawlins Date: Thu, 30 Apr 2026 22:17:56 +0200 Subject: [PATCH 1/2] Use super parameters in more places, linted by the analyzer --- .../framework/scaffold/scaffold_debugger_test.dart | 12 +++--------- .../scaffold/scaffold_debugging_controls_test.dart | 12 +++--------- .../framework/scaffold/scaffold_no_app_test.dart | 14 ++------------ .../framework/scaffold/scaffold_profile_test.dart | 14 ++------------ .../test/framework/scaffold/scaffold_test.dart | 14 ++------------ 5 files changed, 12 insertions(+), 54 deletions(-) diff --git a/packages/devtools_app/test/framework/scaffold/scaffold_debugger_test.dart b/packages/devtools_app/test/framework/scaffold/scaffold_debugger_test.dart index 381e3abac6c..f6ae6d744d5 100644 --- a/packages/devtools_app/test/framework/scaffold/scaffold_debugger_test.dart +++ b/packages/devtools_app/test/framework/scaffold/scaffold_debugger_test.dart @@ -110,15 +110,9 @@ class _TestScreen extends Screen { const _TestScreen( this.name, this.key, { - bool showFloatingDebuggerControls = true, - Key? tabKey, - }) : super( - name, - title: name, - icon: Icons.computer, - tabKey: tabKey, - showFloatingDebuggerControls: showFloatingDebuggerControls, - ); + super.showFloatingDebuggerControls = true, + super.tabKey, + }) : super(name, title: name, icon: Icons.computer); final String name; final Key key; diff --git a/packages/devtools_app/test/framework/scaffold/scaffold_debugging_controls_test.dart b/packages/devtools_app/test/framework/scaffold/scaffold_debugging_controls_test.dart index 09692bdf952..55fc5c98989 100644 --- a/packages/devtools_app/test/framework/scaffold/scaffold_debugging_controls_test.dart +++ b/packages/devtools_app/test/framework/scaffold/scaffold_debugging_controls_test.dart @@ -92,15 +92,9 @@ class _TestScreen extends Screen { const _TestScreen( this.name, this.key, { - bool showFloatingDebuggerControls = true, - Key? tabKey, - }) : super( - name, - title: name, - icon: Icons.computer, - tabKey: tabKey, - showFloatingDebuggerControls: showFloatingDebuggerControls, - ); + super.showFloatingDebuggerControls = true, + super.tabKey, + }) : super(name, title: name, icon: Icons.computer); final String name; final Key key; diff --git a/packages/devtools_app/test/framework/scaffold/scaffold_no_app_test.dart b/packages/devtools_app/test/framework/scaffold/scaffold_no_app_test.dart index aff4cfa7905..a686d5ac3a3 100644 --- a/packages/devtools_app/test/framework/scaffold/scaffold_no_app_test.dart +++ b/packages/devtools_app/test/framework/scaffold/scaffold_no_app_test.dart @@ -77,18 +77,8 @@ void main() { } class _TestScreen extends Screen { - const _TestScreen( - this.name, - this.key, { - bool showFloatingDebuggerControls = true, - Key? tabKey, - }) : super( - name, - title: name, - icon: Icons.computer, - tabKey: tabKey, - showFloatingDebuggerControls: showFloatingDebuggerControls, - ); + const _TestScreen(this.name, this.key, {super.tabKey}) + : super(name, title: name, icon: Icons.computer); final String name; final Key key; diff --git a/packages/devtools_app/test/framework/scaffold/scaffold_profile_test.dart b/packages/devtools_app/test/framework/scaffold/scaffold_profile_test.dart index ea4fbc45e41..2722d8d300a 100644 --- a/packages/devtools_app/test/framework/scaffold/scaffold_profile_test.dart +++ b/packages/devtools_app/test/framework/scaffold/scaffold_profile_test.dart @@ -84,18 +84,8 @@ void main() { } class _TestScreen extends Screen { - const _TestScreen( - this.name, - this.key, { - bool showFloatingDebuggerControls = true, - Key? tabKey, - }) : super( - name, - title: name, - icon: Icons.computer, - tabKey: tabKey, - showFloatingDebuggerControls: showFloatingDebuggerControls, - ); + const _TestScreen(this.name, this.key, {super.tabKey}) + : super(name, title: name, icon: Icons.computer); final String name; final Key key; diff --git a/packages/devtools_app/test/framework/scaffold/scaffold_test.dart b/packages/devtools_app/test/framework/scaffold/scaffold_test.dart index a888a352685..74d806eca1f 100644 --- a/packages/devtools_app/test/framework/scaffold/scaffold_test.dart +++ b/packages/devtools_app/test/framework/scaffold/scaffold_test.dart @@ -291,18 +291,8 @@ void main() { } class _TestScreen extends Screen { - const _TestScreen( - this.name, - this.key, { - bool showFloatingDebuggerControls = true, - Key? tabKey, - }) : super( - name, - title: name, - icon: Icons.computer, - tabKey: tabKey, - showFloatingDebuggerControls: showFloatingDebuggerControls, - ); + const _TestScreen(this.name, this.key, {super.tabKey}) + : super(name, title: name, icon: Icons.computer); final String name; final Key key; From 2659a0cf550e3526fc4854fedaa9fb1a56fd72ba Mon Sep 17 00:00:00 2001 From: Sam Rawlins Date: Thu, 30 Apr 2026 22:41:45 +0200 Subject: [PATCH 2/2] one-more --- .../scaffold/scaffold_debugging_controls_test.dart | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/devtools_app/test/framework/scaffold/scaffold_debugging_controls_test.dart b/packages/devtools_app/test/framework/scaffold/scaffold_debugging_controls_test.dart index 55fc5c98989..a6489ed0c8a 100644 --- a/packages/devtools_app/test/framework/scaffold/scaffold_debugging_controls_test.dart +++ b/packages/devtools_app/test/framework/scaffold/scaffold_debugging_controls_test.dart @@ -89,12 +89,8 @@ void main() { } class _TestScreen extends Screen { - const _TestScreen( - this.name, - this.key, { - super.showFloatingDebuggerControls = true, - super.tabKey, - }) : super(name, title: name, icon: Icons.computer); + const _TestScreen(this.name, this.key, {super.tabKey}) + : super(name, title: name, icon: Icons.computer); final String name; final Key key;