Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary call to find the App.framework. #10178

Merged
merged 2 commits into from Jul 26, 2019

Conversation

@gaaclarke
Copy link
Contributor

commented Jul 26, 2019

This is necessary for UITests, but regular tests are built into the same app bundle so it isn't necessary here (not to mention the typo in it).

This is necessary for UITests, but regular tests are built into
the same app bundle so it isn't necessary.
@googlebot googlebot added the cla: yes label Jul 26, 2019
@gaaclarke gaaclarke requested a review from jmagman Jul 26, 2019
@gaaclarke

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

Landing on red, the luci break was just a goma exception. This can't break anything because it isn't integrated yet.

@gaaclarke gaaclarke merged commit a4778ea into flutter:master Jul 26, 2019
18 of 19 checks passed
18 of 19 checks passed
luci-engine luci-engine is currently broken. Please do not merge this PR unless it contains a fix to the broken build.
Details
WIP Ready for review
Details
build_and_test_android_unopt_debug Task Summary
Details
build_and_test_android_unopt_debug
Details
build_and_test_linux_opt_profile Task Summary
Details
build_and_test_linux_opt_profile
Details
build_and_test_linux_opt_release Task Summary
Details
build_and_test_linux_opt_release
Details
build_and_test_linux_unopt_debug Task Summary
Details
build_and_test_linux_unopt_debug
Details
build_fuchsia_unopt_profile Task Summary
Details
build_fuchsia_unopt_profile
Details
build_windows_opt_debug Task Summary
Details
build_windows_opt_debug
Details
build_windows_unopt_debug Task Summary
Details
build_windows_unopt_debug
Details
cla/google All necessary CLAs are signed
format_and_dart_test Task Summary
Details
format_and_dart_test
Details
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jul 27, 2019
flutter/engine@3e0cff2...bb2e7a6

git log 3e0cff2a6142c0f07fea7a84a3ceb9e36d1db5bb..bb2e7a615cb19b4ca6e66b5145ed67a6b13760e8 --no-merges --oneline
bb2e7a615 Roll src/third_party/skia 14963cef70cc..ff5d7a2f9033 (4 commits) (flutter/engine#10193)
6b2157f58 Roll fuchsia/sdk/core/linux-amd64 from 4UIZFD0vdZLUDS9k1fP7RRJ1GV48wRQ7-yqjkKVbDvcC to TA0dEf--c1b-EPkEzP27uqiCqVM2Noh-cOraEoXG-kMC (flutter/engine#10190)
69e0800ca [fuchsia] Artifacts now contain gen_snapshot and gen_snapshot_product (flutter/engine#10188)
358c72966 Roll fuchsia/sdk/core/mac-amd64 from sygT6NTtnUPSogR7MOMaqVm49W_8wi57rIJpNpOJ-jQC to 2EmJ-Ug89PGpagl0Me9qokZqsT61PSvUfuZasACGK5AC (flutter/engine#10187)
aea0d7a65 test scenario_app on CI (flutter/engine#10065)
67524615b Add better CIPD docs. (flutter/engine#10185)
f33b2d420 Uncommemt publish to CIPD (flutter/engine#10183)
e10a19fad Roll src/third_party/skia 66ed6a0cad6d..14963cef70cc (9 commits) (flutter/engine#10181)
e1ab0fc31 Roll src/third_party/dart 86dba81dec..0ca1582afd (2 commits) (flutter/engine#10160)
3e3efe4c6 [dart_runner] dart jit runner and dart jit product runner (flutter/engine#10179)
4b587a6c6 Roll fuchsia/sdk/core/linux-amd64 from tKTQX9s1EPV7nn9f81lwxk2xIr3wL220KA6BGv-sceMC to 4UIZFD0vdZLUDS9k1fP7RRJ1GV48wRQ7-yqjkKVbDvcC (flutter/engine#10180)
be9b24569 add suggested changes from flutter roll (flutter/engine#10176)
318c8c533 Roll fuchsia/sdk/core/mac-amd64 from SjR5fqBfe7qxjHNWDZx6381UbPUcw78mDI9dFAIN-Y4C to sygT6NTtnUPSogR7MOMaqVm49W_8wi57rIJpNpOJ-jQC (flutter/engine#10177)
a4778eafb Removed unnecessary call to find the App.framework. (flutter/engine#10178)
2dc03ab51 Added integration test that tests that the first frame callback is called (flutter/engine#10145)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.
johnsonmh added a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
flutter/engine@3e0cff2...bb2e7a6

git log 3e0cff2a6142c0f07fea7a84a3ceb9e36d1db5bb..bb2e7a615cb19b4ca6e66b5145ed67a6b13760e8 --no-merges --oneline
bb2e7a615 Roll src/third_party/skia 14963cef70cc..ff5d7a2f9033 (4 commits) (flutter/engine#10193)
6b2157f58 Roll fuchsia/sdk/core/linux-amd64 from 4UIZFD0vdZLUDS9k1fP7RRJ1GV48wRQ7-yqjkKVbDvcC to TA0dEf--c1b-EPkEzP27uqiCqVM2Noh-cOraEoXG-kMC (flutter/engine#10190)
69e0800ca [fuchsia] Artifacts now contain gen_snapshot and gen_snapshot_product (flutter/engine#10188)
358c72966 Roll fuchsia/sdk/core/mac-amd64 from sygT6NTtnUPSogR7MOMaqVm49W_8wi57rIJpNpOJ-jQC to 2EmJ-Ug89PGpagl0Me9qokZqsT61PSvUfuZasACGK5AC (flutter/engine#10187)
aea0d7a65 test scenario_app on CI (flutter/engine#10065)
67524615b Add better CIPD docs. (flutter/engine#10185)
f33b2d420 Uncommemt publish to CIPD (flutter/engine#10183)
e10a19fad Roll src/third_party/skia 66ed6a0cad6d..14963cef70cc (9 commits) (flutter/engine#10181)
e1ab0fc31 Roll src/third_party/dart 86dba81dec..0ca1582afd (2 commits) (flutter/engine#10160)
3e3efe4c6 [dart_runner] dart jit runner and dart jit product runner (flutter/engine#10179)
4b587a6c6 Roll fuchsia/sdk/core/linux-amd64 from tKTQX9s1EPV7nn9f81lwxk2xIr3wL220KA6BGv-sceMC to 4UIZFD0vdZLUDS9k1fP7RRJ1GV48wRQ7-yqjkKVbDvcC (flutter/engine#10180)
be9b24569 add suggested changes from flutter roll (flutter/engine#10176)
318c8c533 Roll fuchsia/sdk/core/mac-amd64 from SjR5fqBfe7qxjHNWDZx6381UbPUcw78mDI9dFAIN-Y4C to sygT6NTtnUPSogR7MOMaqVm49W_8wi57rIJpNpOJ-jQC (flutter/engine#10177)
a4778eafb Removed unnecessary call to find the App.framework. (flutter/engine#10178)
2dc03ab51 Added integration test that tests that the first frame callback is called (flutter/engine#10145)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.