[flutter] Create the compositor context on the GPU task runner. #10781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compositor context owns the session connection. The creation of the session connection also does the initial present to clear the node hierarchy. This present was happening perviously on the platform task runner while all subsequent presents were on the GPU task runner. This has now been rectified so all presents are on the GPU task runner. BUG: FL-288 Change-Id: Ib294666ffb3b4575f93ad0b02a5d0fda71bfa0a8
chinmaygarde
approved these changes
Aug 8, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2019
This was referenced Aug 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 9, 2019
git@github.com:flutter/engine.git/compare/d9bbe37ce376...dd735c9 git log d9bbe37..dd735c9 --no-merges --oneline 2019-08-09 iska.kaushik@gmail.com [flutter_runner] Improve frame scheduling (flutter/engine#10780) 2019-08-09 iska.kaushik@gmail.com [flutter] Create the compositor context on the GPU task runner. (flutter/engine#10781) 2019-08-09 chinmaygarde@gmail.com Revert "Forwards iOS dark mode trait to the Flutter framework (#34441). (#9722)" (flutter/engine#10789) 2019-08-08 matthew-carroll@users.noreply.github.com Forwards iOS dark mode trait to the Flutter framework (#34441). (flutter/engine#9722) 2019-08-08 dnfield@google.com Specify which android variant for tests (flutter/engine#10717) 2019-08-08 dnfield@google.com Don't use gradle daemon for building (flutter/engine#10771) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (jimgraham@google.com), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compositor context owns the session connection. The creation of the
session connection also does the initial present to clear the node
hierarchy. This present was happening perviously on the platform task
runner while all subsequent presents were on the GPU task runner. This
has now been rectified so all presents are on the GPU task runner.
BUG: FL-288
Change-Id: Ib294666ffb3b4575f93ad0b02a5d0fda71bfa0a8