Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all license diffs #11034

Merged
merged 2 commits into from Aug 19, 2019

Conversation

@stuartmorgan
Copy link
Contributor

commented Aug 15, 2019

Instead of gathering all license diffs but only showing the changes to
the first directory that has a diff, show all diffs before exiting
licenses.sh.

Fixes flutter/flutter#38634

Instead of gathering all license diffs but only showing the changes to
the first directory that has a diff, show all diffs before exiting
licenses.sh.

Fixes flutter/flutter#38634
@stuartmorgan stuartmorgan requested review from cbracken and Hixie Aug 15, 2019
@googlebot googlebot added the cla: yes label Aug 15, 2019
@stuartmorgan stuartmorgan merged commit 19327c8 into flutter:master Aug 19, 2019
7 of 12 checks passed
7 of 12 checks passed
build_and_test_android_unopt_debug
Details
build_and_test_linux_unopt_debug
Details
build_windows_opt_debug
Details
build_windows_unopt_debug
Details
format_and_dart_test
Details
WIP Ready for review
Details
build_and_test_android_unopt_debug Task Summary
Details
build_and_test_linux_unopt_debug Task Summary
Details
build_windows_opt_debug Task Summary
Details
build_windows_unopt_debug Task Summary
Details
cla/google All necessary CLAs are signed
format_and_dart_test Task Summary
Details
@stuartmorgan stuartmorgan deleted the stuartmorgan:license-show-all-diffs branch Aug 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2019
iskakaushik added a commit to flutter/flutter that referenced this pull request Aug 19, 2019
* 19327c8b7 Show all license diffs (flutter/engine#11034)

* e97ed36e5 Add a BroadcastStream to FrameTiming (flutter/engine#11041)

* 21ae92651 [b/139487101] Dont present session twice (flutter/engine#11222)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.