Roll ICU to c2a4cae149aae7fd30c4cbe3cf1b30df03b386f1 #22465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmil
force-pushed
the
upgrade-icu-to-68.1
branch
16 times, most recently
from
417ea59
to
0669706
Compare
|
@iskakaushik PTAL. Not sure what I can do about the luci-engine failure. |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
filmil
force-pushed
the
upgrade-icu-to-68.1
branch
2 times, most recently
from
868d2a1
to
15f0473
Compare
|
@iskakaushik I will need someone on Flutter team to merge this, assuming that I win the |
Changes to make this work: - Had to change the use of an UBool constant `FALSE` to 0 because the file referring to it does not include the respective header. - Had to change the license checker to ignore files in the directory icu/source/samples. There were random changes to the licensing headers which tripped up license checks. And since we don't include samples in the binaries we build, the most efficient way to fix it is to exclude sample code from license checks. Issue: flutter/flutter#70370
filmil
force-pushed
the
upgrade-icu-to-68.1
branch
from
15f0473
to
3846754
Compare
|
Thank you! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2020
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
Changes to make this work: - Had to change the use of an UBool constant `FALSE` to 0 because the file referring to it does not include the respective header. - Had to change the license checker to ignore files in the directory icu/source/samples. There were random changes to the licensing headers which tripped up license checks. And since we don't include samples in the binaries we build, the most efficient way to fix it is to exclude sample code from license checks. Issue: flutter/flutter#70370
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: flutter/flutter#70370
Description
Related Issues
Tests
N/A, this is a library dependency update.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Reviewer Checklist
Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.