Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Started waiting for the notifications locally before assertin… #25248

Merged
merged 1 commit into from Mar 25, 2021
Merged

Revert "Started waiting for the notifications locally before assertin… #25248

merged 1 commit into from Mar 25, 2021

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Mar 25, 2021 •
edited

…g side effects (#25226)"

This reverts commit 8726c78.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke requested a review from jmagman March 25, 2021 20:36
jmagman
jmagman approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaaclarke
Copy link
Member Author

landing on red to open the tree

@gaaclarke gaaclarke merged commit 7e18491 into flutter:master Mar 25, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2021
@engine-flutter-autoroll
7e18491 Revert "Started waiting for the notifications locally before …
d8d8923 
…asserting side effects (flutter#25226)" (flutter/engine#25248)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2021
@engine-flutter-autoroll
7e18491 Revert "Started waiting for the notifications locally before …
3441ded 
…asserting side effects (flutter#25226)" (flutter/engine#25248)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2021
@engine-flutter-autoroll
7e18491 Revert "Started waiting for the notifications locally before …
ea52543 
…asserting side effects (flutter#25226)" (flutter/engine#25248)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2021
@engine-flutter-autoroll
7e18491 Revert "Started waiting for the notifications locally before …
f26b59f 
…asserting side effects (flutter#25226)" (flutter/engine#25248)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2021
@engine-flutter-autoroll
7e18491 Revert "Started waiting for the notifications locally before …
96ee530 
…asserting side effects (flutter#25226)" (flutter/engine#25248)
chandarrengoog pushed a commit to chandarrengoog/engine that referenced this pull request Mar 30, 2021
@gaaclarke @chandarrengoog
Revert "Started waiting for the notifications locally before assertin…
1530a9e 
…g side effects (flutter#25226)" (flutter#25248)

This reverts commit 8726c78.
duanqz pushed a commit to duanqz/engine that referenced this pull request Apr 16, 2021
@gaaclarke @duanqz
Revert "Started waiting for the notifications locally before assertin…
b74d5bd 
…g side effects (flutter#25226)" (flutter#25248)

This reverts commit 8726c78.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

Assignees
No one assigned
Labels
cla: yes platform-ios
Projects
None yet
Milestone
No milestone
3 participants
@gaaclarke @jmagman @googlebot