Add clear method in FlutterEngineCache to clear all cached Flutter engines #78420 #25280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarlChow92
changed the title
xster
reviewed
Mar 29, 2021
| // --- Execute Test --- | ||
| cache.put("my_flutter_engine", flutterEngine); | ||
| cache.put("my_flutter_engine_2", flutterEngine2); | ||
| cache.clear(); |
There was a problem hiding this comment.
assert here that those engines are indeed there and equal to flutterEngine and flutterEngine2 before clearing
There was a problem hiding this comment.
Thank you for your comment, I've made another commit, mind to re-check?
xster
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 30, 2021
chandarrengoog
pushed a commit
to chandarrengoog/engine
that referenced
this pull request
Mar 30, 2021
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to resolve #78420. I added the clear method as of the suggestion and added a test case to verify my implementation. In the implementation, I just reused the
Map's clear method to implement this.