Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPIR-V FragmentShader API to painting.dart #26996

Merged
merged 130 commits into from Aug 18, 2021

Conversation

clocksmith
Copy link
Contributor

@clocksmith clocksmith commented Jun 27, 2021

Co-authored-by Christopher Crawford chriscraws@gmail.com

closes flutter/flutter#85237
partially addresses flutter/flutter#85239

  • Add a SPIRV FragmentShader interface in painting.dart
  • Create end to end pixel tests for ops supported by the SPIRV to SkSL transpiler
  • The end to end test also test the c++ fragment shader implementation

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the [engine presubmit flakes form] before re-triggering the failure.

@clocksmith clocksmith added the Work in progress (WIP) Not ready (yet) for review! label Jun 27, 2021
@google-cla google-cla bot added the cla: yes label Jun 27, 2021
@clocksmith clocksmith closed this Jun 27, 2021
@clocksmith clocksmith reopened this Jun 30, 2021
@clocksmith clocksmith changed the title Fragment shader Add FragmentShader API to painting.dart Jun 30, 2021
@clocksmith clocksmith changed the title Add FragmentShader API to painting.dart Add SPIR-V FragmentShader API to painting.dart Jun 30, 2021
@google-cla google-cla bot added cla: no and removed cla: yes labels Jul 27, 2021
@clocksmith
Copy link
Contributor Author

This is mostly ready, leaving WIP tag on, but would like to collect feedback and comments (specifically on testing strategy and API) @chinmaygarde @zanderso

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to FlutterActivityDelegate.java, _embedder.yaml, and clang_tidy_test.dart in this PR appear to be the result of a bad merge/rebase, and I suspect are what is confusing the CLA bot.

@clocksmith clocksmith removed the Work in progress (WIP) Not ready (yet) for review! label Jul 28, 2021
@chriscraws
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 29, 2021
@clocksmith
Copy link
Contributor Author

License issues fixed but tree is now broken 💔

@clocksmith clocksmith merged commit 6d6ce34 into flutter:master Aug 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2021
zanderso added a commit that referenced this pull request Aug 19, 2021
zanderso added a commit that referenced this pull request Aug 19, 2021
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Aug 23, 2021
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
Add SPIR-V FragmentShader API to painting.dart
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants