This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add gclient parser. #32135
Merged
Add gclient parser. #32135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is the initial version of the gclient flattening script that will be used to validate dependencies are pinned. |
chinmaygarde
approved these changes
Mar 24, 2022
zanderso
reviewed
Mar 24, 2022
| @@ -0,0 +1,96 @@ | |||
| # Usage: deps_parser.py --deps <DEPS file> --output <flattened deps> | |||
Contributor
Author
There was a problem hiding this comment.
Added the copyright header. Do we also need to update the licenses scripts to check python files?
Member
There was a problem hiding this comment.
The license script is only for checking code that might ship. The ci directory is excluded.
zanderso
approved these changes
Mar 25, 2022
| @@ -0,0 +1,96 @@ | |||
| # Usage: deps_parser.py --deps <DEPS file> --output <flattened deps> | |||
Member
There was a problem hiding this comment.
The license script is only for checking code that might ship. The ci directory is excluded.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 25, 2022
* 0defb26 Add gclient parser. (flutter/engine#32135) * b8ff8f1 Roll impeller to 0ce2e789fc0852d6d9ee63fb68097327447cd7d8 (flutter/engine#32264) * 6096dd1 Add test for external textures on Android (flutter/engine#31642)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parses gclient DEPs file to be processed later by scorecards.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.