fix missing forward of defines in dart_runner build #33412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akbiggs
approved these changes
May 17, 2022
naudzghebre
approved these changes
May 17, 2022
CaseyHillers
pushed a commit
to CaseyHillers/engine
that referenced
this pull request
May 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 17, 2022
CaseyHillers
pushed a commit
to CaseyHillers/engine
that referenced
this pull request
May 18, 2022
CaseyHillers
pushed a commit
that referenced
this pull request
May 18, 2022
CaseyHillers
pushed a commit
to CaseyHillers/engine
that referenced
this pull request
May 19, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving to a source set the we were not picking up the extra_defines so AOT_RUNTIME was being ignored in the dart_runner.cc class. This change will forward the defines to the runner sources as well.