This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Prevent TalkBack from announcing view in non-virtual a11y hierarchies #34017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryQian
reviewed
Jun 14, 2022
| embeddedView.setLayoutParams(new FrameLayout.LayoutParams(physicalWidth, physicalHeight)); | ||
| embeddedView.setLayoutDirection(request.direction); | ||
|
|
||
| // Accessibility is initially disabled, and it's e-enabled by AccessibilityBridge after |
Contributor
There was a problem hiding this comment.
This comment describes the scenario but does not clearly state why this must be set to disabled here specifically at this time. What is the value if it is not explicitly set here?
GaryQian
approved these changes
Jun 14, 2022
blasten
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 14, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that accessibility events aren't forwarded to the parent view when
the embedded view should not be read by TalkBack.
Code sample
Fixes flutter/flutter#105658
Fixes flutter/flutter#29717