Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

WIP: macOS: Fix platform view threading issues #35894

Closed
wants to merge 1 commit into from

Conversation

knopp
Copy link
Member

@knopp knopp commented Sep 2, 2022

Fixes flutter/flutter#96668

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@zanderso
Copy link
Member

zanderso commented Sep 8, 2022

From PR review triage: Adding the WIP label.

@knopp knopp force-pushed the macos_platform_view_threading branch from 233f477 to 0727db3 Compare November 10, 2022 12:59
@knopp knopp force-pushed the macos_platform_view_threading branch from 0727db3 to 78e3020 Compare November 20, 2022 13:17
@knopp
Copy link
Member Author

knopp commented Nov 20, 2022

Closing in favor of #37789.

@knopp knopp closed this Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform-macos Work in progress (WIP) Not ready (yet) for review!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macos] Platform views must be mutated on Main thread
2 participants